vaful commented on a change in pull request #533: kylin-3812 optimize the child
CompareTupleFilter in a CompareTupleFilter
URL: https://github.com/apache/kylin/pull/533#discussion_r269391576
##########
File path:
core-metadata/src/main/java/org/apache/kylin/metadata/filter/CompareTupleFilter.java
##########
@@ -74,6 +77,9 @@ private CompareTupleFilter(CompareTupleFilter another) {
@Override
public void addChild(TupleFilter child) {
+ if (child instanceof CompareTupleFilter) {
Review comment:
plz add some test case in UT or IT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
