shaofengshi commented on a change in pull request #561: KYLIN-3915 Make
HADOOP_CLASSPATH configurable for Flink engine
URL: https://github.com/apache/kylin/pull/561#discussion_r269982478
##########
File path:
engine-flink/src/main/java/org/apache/kylin/engine/flink/FlinkExecutable.java
##########
@@ -171,35 +171,37 @@ protected ExecuteResult doWork(ExecutableContext
context) throws ExecuteExceptio
Segments<CubeSegment> mergingSeg =
cube.getMergingSegments(segment);
dumpMetadata(segment, mergingSeg);
+ Map<String, String> flinkConfs = config.getFlinkConfigOverride();
+ String hadoopClasspathEnv =
flinkConfs.get(ENV_HADOOP_CLASSPATH_KEY);
+
StringBuilder sb = new StringBuilder();
if (Shell.osType == Shell.OSType.OS_TYPE_WIN) {
- sb.append("set HADOOP_CONF_DIR=%s && export
HADOOP_CLASSPATH=/usr/hdp/2.4.0.0-169/hadoop/ && %s/bin/flink run -m
yarn-cluster ");
+ sb.append("set HADOOP_CONF_DIR=%s && export
HADOOP_CLASSPATH=%s && %s/bin/flink run -m yarn-cluster ");
Review comment:
should "HADOOP_CLASSPATH" also use "set" instead of "export"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
