kyotoYaho commented on a change in pull request #533: kylin-3812 optimize the
child CompareTupleFilter in a CompareTupleFilter
URL: https://github.com/apache/kylin/pull/533#discussion_r273514735
##########
File path:
core-metadata/src/main/java/org/apache/kylin/metadata/filter/CompareTupleFilter.java
##########
@@ -74,6 +77,9 @@ private CompareTupleFilter(CompareTupleFilter another) {
@Override
public void addChild(TupleFilter child) {
+ if (child instanceof CompareTupleFilter) {
Review comment:
We need to refine our IT and add more test cases. To test this case, it's
necessary to add a column with boolean type. However, it's a trivial job and
may need another JIRA to work this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
