[
https://issues.apache.org/jira/browse/KYLIN-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vsevolod Ostapenko reopened KYLIN-3842:
---------------------------------------
_config is one long string that is being searched using simple indexOf (instead
of regex).
The recent changes introduce regression where partial matches will be falsely
picked up.
For example, while searching for property XYZ the following case, incorrect
property assignment will be picked:
{quote}{{# XYZ=foo}}
abcXYZ=bar
XYZ=expected_value{quote}
A trivial fix for the issue with the very first property in the property file
that doesn't start with a comment is to prepend "\n" to _config upon
initialization, if the first character of _config is not "\n".
> kylinProperties.js Unable to get the public configuration of the first line
> in the front end
> --------------------------------------------------------------------------------------------
>
> Key: KYLIN-3842
> URL: https://issues.apache.org/jira/browse/KYLIN-3842
> Project: Kylin
> Issue Type: Bug
> Components: Web
> Affects Versions: v2.5.2
> Reporter: Yuzhang QIU
> Assignee: Yuzhang QIU
> Priority: Minor
> Fix For: v2.6.2
>
>
> Hi dear team:
> I'm developing OLAP Platform based on Kylin2.5.2. During my work, I found
> that kylinProperties.js:37(getProperty(name)) can't get the property of the
> first line in the '_config' which initialized through /admin/public_config.
> For example, the public config is
> 'kylin.restclient.connection.default-max-per-route=20\nkylin.restclient.connection.max-total=200\nkylin.engine.default=2\nkylin.storage.default=2\n
> kylin.web.hive-limit=20\nkylin.web.help.length=4\n'. I expected to get 20
> but got '' when I want to get config by key
> 'kylin.restclient.connection.default-max-per-route'. This problem caused by
> 'var keyIndex = _config.indexOf('\n' + name + '=');'(at
> kylinProperties.js:37) return -1 for those names before which don't have an
> \n(at the first line).
> Then, I debug the AdminService.java, KylinConfig.java and found that the
> KylinConfig.java:517(around this line, in method
> exportToString(Collection<String> propertyKeys)) build the public config
> string with a char '\n' after each property, which cause the first property
> don't has '\n' before it.
> Those are what I found, which will cause problem for developers.
> How do you think?
> Best regard
> yuzhang
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
