nichunen commented on a change in pull request #611: KYLIN-3943 Fix some
problems in system-cube.sh
URL: https://github.com/apache/kylin/pull/611#discussion_r277295120
##########
File path: build/bin/system-cube.sh
##########
@@ -53,7 +66,12 @@ elif [ "$1" == "setup" ]
then
#creat SCSinkTools.json
SINK_TOOLS_FILE=$KYLIN_HOME/SCSinkTools.json
- cat <<- EOF > ${SINK_TOOLS_FILE}
+
+ echo "setup system cubes"
+
+ rm -rf $SINK_TOOLS_FILE $OUTPUT_FORDER
Review comment:
will the script stopped if no file $OUTPUT_FORDER existed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
