nichunen commented on issue #612: KYLIN-3961 Optimize TopNCounter's merge function to reduce TopNCounter's error size. URL: https://github.com/apache/kylin/pull/612#issuecomment-492491490 Hi @zhaojintaozhao I agree that your pr will increase the accuracy of the counter number in some cases, but I'm afraid it will also break the results' oder. Look at the ut I've added in your pr. The counter with item "DD" is supposed to be the top 1 after two times of merging, but with the code change, it will be lost
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
