ZhengshuaiPENG commented on a change in pull request #633: KYLIN-3994:
StorageCleanupJob may delete cube id data of new built segment because of cube
cache in CubeManager
URL: https://github.com/apache/kylin/pull/633#discussion_r288895268
##########
File path:
server-base/src/main/java/org/apache/kylin/rest/job/MetadataCleanupJob.java
##########
@@ -122,7 +122,7 @@ public MetadataCleanupJob(KylinConfig config) {
// exclude resources in use
Set<String> activeResources = Sets.newHashSet();
- for (CubeInstance cube : cubeManager.listAllCubes()) {
+ for (CubeInstance cube : cubeManager.reloadAndListAllCubes()) {
Review comment:
In fact here when getting the `toDeleteCandidates`, it filters at candidates
who were generated before NEW_RESOURCE_THRESHOLD_MS (12 hours). I think don't
need to reload cube here. But it's OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
