wangxiaojing123 commented on a change in pull request #664: KYLIN-4017 Build
engine get zk(zookeeper) lock failed when building job, it causes the whole
build engine doesn't work
URL: https://github.com/apache/kylin/pull/664#discussion_r292799574
##########
File path: core-common/src/main/java/org/apache/kylin/common/util/ZKUtil.java
##########
@@ -84,7 +84,7 @@ public void onRemoval(RemovalNotification<String,
CuratorFramework> notification
logger.error("Error at closing " + curator, ex);
}
}
- }).expireAfterWrite(1, TimeUnit.DAYS).build();
+ }).expireAfterWrite(10000, TimeUnit.DAYS).build();//never expired
Review comment:
@nichunen Hello nichunen,Thank you reply. "My concern is why after the cache
of curator expired, the newly created zookeeper client is not in state of
CuratorFrameworkState.STARTED?" Besause now the code never start a new
zookeeper client, it use the old one which state is closed。The new code in my
patch I add two changes:1、never expire,2、in case of client is closed, create a
new one (but before ,there is no this feature) .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
