zhaojintaozhao commented on a change in pull request #661: KYLIN-4015 "Build UHC Dictionary" step filter ".dci" files URL: https://github.com/apache/kylin/pull/661#discussion_r292905054
########## File path: engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/filter/UHCDictPathFilter.java ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. +*/ + +package org.apache.kylin.engine.mr.steps.filter; + +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.fs.PathFilter; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.Locale; +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +public class UHCDictPathFilter implements PathFilter { + private static final Logger logger = LoggerFactory.getLogger(UHCDictPathFilter.class); + + private static final String DCIFILE_POSTFIX = ".dci"; + + @Override + public boolean accept(Path path) { + + Pattern pattern = Pattern.compile(DCIFILE_POSTFIX); + Matcher matcher = pattern.matcher(path.getName().toLowerCase(Locale.ROOT)); + + if (matcher.find()) { + logger.info("filter file: " + path.getName()); + return false; Review comment: Hi Shaofeng How can we implement it with a whitelist way? After "Extract Fact Table Distinct Columns" step, Kylin generate files like "colName.dci-r-00001", "colName.rldict-r-00002" or "-r-00002","-r-00003". After filtering path, only file name like ".rldict-r-00001" or "-r-00002" are retained? I want to check whether the type of hdfs file is "SequenceFile", but I don't find any hadoop API can provide this ability. Hadoop does not perceive the specific type of file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
