nichunen commented on a change in pull request #671: KYLIN-4026: Avoid too many
file append operations in HiveProducer of of hive metrics reporter
URL: https://github.com/apache/kylin/pull/671#discussion_r295099633
##########
File path:
core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/BlockingReservoir.java
##########
@@ -93,7 +96,7 @@ private void onRecordUpdate(boolean ifAll) {
if (!notifyListenerOfUpdatedRecord(listener, records)) {
ifSucceed = false;
logger.warn("It fails to notify listener " +
listener.toString() + " of updated records "
Review comment:
how about change the log "updated records" to "updated record size"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
