[
https://issues.apache.org/jira/browse/KYLIN-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876822#comment-16876822
]
ASF GitHub Bot commented on KYLIN-4062:
---------------------------------------
RupengWang commented on pull request #725: KYLIN-4062 Using a static hashmap to
replace many "if-else" to improv…
URL: https://github.com/apache/kylin/pull/725
…e efficiency
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Too many "if else" clause in PushDownRunnerJdbcImpl#toSqlType
> -------------------------------------------------------------
>
> Key: KYLIN-4062
> URL: https://issues.apache.org/jira/browse/KYLIN-4062
> Project: Kylin
> Issue Type: Improvement
> Components: Query Engine
> Reporter: Shaofeng SHI
> Assignee: 王汝鹏
> Priority: Minor
>
> In this method, it has 30 "if else" which is low efficient; Should use a
> static Hashmap, then only need 1 check.
>
> {code:java}
> if ("string".equalsIgnoreCase(type)) {
> return Types.VARCHAR;
> } else if ("varchar".equalsIgnoreCase(type)) {
> return Types.VARCHAR;
> } else if ("char".equalsIgnoreCase(type)) {
> return Types.CHAR;
> } else if
> ...{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
