codecov-io commented on issue #734: KYLIN-4039, fix ZK distributed lock may not release lock when catchin… URL: https://github.com/apache/kylin/pull/734#issuecomment-514210802 # [Codecov](https://codecov.io/gh/apache/kylin/pull/734?src=pr&el=h1) Report > Merging [#734](https://codecov.io/gh/apache/kylin/pull/734?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/96ba0c66889e0caa29f52c3d740536ef81d8dc5c?src=pr&el=desc) will **increase** coverage by `0.03%`. > The diff coverage is `39.02%`. [](https://codecov.io/gh/apache/kylin/pull/734?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #734 +/- ## ============================================ + Coverage 25.72% 25.76% +0.03% - Complexity 6019 6041 +22 ============================================ Files 1386 1393 +7 Lines 82708 82968 +260 Branches 11599 11602 +3 ============================================ + Hits 21280 21373 +93 - Misses 59379 59539 +160 - Partials 2049 2056 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/734?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...java/org/apache/kylin/job/util/ThrowableUtils.java](https://codecov.io/gh/apache/kylin/pull/734/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi91dGlsL1Rocm93YWJsZVV0aWxzLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...ck/zookeeper/exception/ZkAcquireLockException.java](https://codecov.io/gh/apache/kylin/pull/734/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9sb2NrL3pvb2tlZXBlci9leGNlcHRpb24vWmtBY3F1aXJlTG9ja0V4Y2VwdGlvbi5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../lock/zookeeper/exception/ZkPeekLockException.java](https://codecov.io/gh/apache/kylin/pull/734/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9sb2NrL3pvb2tlZXBlci9leGNlcHRpb24vWmtQZWVrTG9ja0V4Y2VwdGlvbi5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...keeper/exception/ZkPeekLockInterruptException.java](https://codecov.io/gh/apache/kylin/pull/734/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9sb2NrL3pvb2tlZXBlci9leGNlcHRpb24vWmtQZWVrTG9ja0ludGVycnVwdEV4Y2VwdGlvbi5qYXZh) | `20% <20%> (ø)` | `1 <1> (?)` | | | [...per/exception/ZkReleaseLockInterruptException.java](https://codecov.io/gh/apache/kylin/pull/734/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9sb2NrL3pvb2tlZXBlci9leGNlcHRpb24vWmtSZWxlYXNlTG9ja0ludGVycnVwdEV4Y2VwdGlvbi5qYXZh) | `20% <20%> (ø)` | `1 <1> (?)` | | | [...ck/zookeeper/exception/ZkReleaseLockException.java](https://codecov.io/gh/apache/kylin/pull/734/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9sb2NrL3pvb2tlZXBlci9leGNlcHRpb24vWmtSZWxlYXNlTG9ja0V4Y2VwdGlvbi5qYXZh) | `20% <20%> (ø)` | `1 <1> (?)` | | | [...n/job/lock/zookeeper/ZookeeperDistributedLock.java](https://codecov.io/gh/apache/kylin/pull/734/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9sb2NrL3pvb2tlZXBlci9ab29rZWVwZXJEaXN0cmlidXRlZExvY2suamF2YQ==) | `54.67% <61.76%> (+54.67%)` | `18 <5> (+18)` | :arrow_up: | | [...he/kylin/stream/core/metrics/StreamingMetrics.java](https://codecov.io/gh/apache/kylin/pull/734/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL21ldHJpY3MvU3RyZWFtaW5nTWV0cmljcy5qYXZh) | `23.07% <0%> (-43.59%)` | `4% <0%> (ø)` | | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/734/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | | | [...core/storage/columnar/GeneralColumnDataReader.java](https://codecov.io/gh/apache/kylin/pull/734/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvR2VuZXJhbENvbHVtbkRhdGFSZWFkZXIuamF2YQ==) | `89.47% <0%> (-5.27%)` | `6% <0%> (-1%)` | | | ... and [44 more](https://codecov.io/gh/apache/kylin/pull/734/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/734?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/734?src=pr&el=footer). Last update [96ba0c6...3f3172e](https://codecov.io/gh/apache/kylin/pull/734?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
