nichunen commented on a change in pull request #757: KYLIN-3917: Add max
segment merge span to cleanup intermediate data of cube building
URL: https://github.com/apache/kylin/pull/757#discussion_r311002905
##########
File path:
core-metadata/src/main/java/org/apache/kylin/metadata/model/Segments.java
##########
@@ -189,6 +195,21 @@ public void
removeLatestSegmentByVolatileRange(Segments<T> segs, long volatileRa
}
+ public void removeMaxSpanSegment(Segments<T> segs, long maxSegSpan) {
+ if (maxSegSpan <= 0) {
+ return;
+ }
+ Segments maxSpanSegs = new Segments();
+ for (T seg : segs) {
Review comment:
Is there any possibility of inner segment(s) being skipped?
For instance, there are 3 segments like
20190101-20190102, 20190102-20190210, 20190110-20190211.
The method will remove 20190102-20190210, and 2 no-adjacent segments try to
be merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
