hit-lacus commented on a change in pull request #835: KYLIN-4159 The first step
of job will fail and throw "Column \'xx\' i…
URL: https://github.com/apache/kylin/pull/835#discussion_r322540274
##########
File path:
source-jdbc/src/main/java/org/apache/kylin/source/jdbc/JdbcHiveInputBase.java
##########
@@ -222,11 +223,13 @@ protected AbstractExecutable
createSqoopToFlatHiveStep(String jobWorkingDir, Str
String splitTableAlias;
String splitColumn;
+ String quoteFullNamedColumn; // `table.column`
String splitDatabase;
TblColRef splitColRef = determineSplitColumn();
splitTableAlias = splitColRef.getTableAlias();
splitColumn = getColumnIdentityQuoted(splitColRef,
jdbcMetadataDialect, metaMap, true);
+ quoteFullNamedColumn = quoteIdentifier(partCol,
jdbcMetadataDialect.getDialect()).toLowerCase();
Review comment:
Use `toLowerCase` is forbidden.
```
Forbidden method invocation: java.lang.String#toLowerCase() [Uses default
locale]
[ERROR] in
org.apache.kylin.source.jdbc.JdbcHiveInputBase$JdbcBaseBatchCubingInputSide
(JdbcHiveInputBase.java:232)
```
[ERROR] Scanned 34 (and 354 related) class file(s) for forbidden API
invocations (in 0.10s), 1 error(s).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
