[
https://issues.apache.org/jira/browse/KYLIN-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953576#comment-16953576
]
ASF GitHub Bot commented on KYLIN-4097:
---------------------------------------
Sean-Gu commented on pull request #892: Revert "KYLIN-4097: Throw exception
when too many dict slice evictions in AppendTrieDictionary"
URL: https://github.com/apache/kylin/pull/892
Reverts apache/kylin#760 for now duo to Failure of regression test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Throw exception when too many dict slice eviction in AppendTrieDictionary
> -------------------------------------------------------------------------
>
> Key: KYLIN-4097
> URL: https://issues.apache.org/jira/browse/KYLIN-4097
> Project: Kylin
> Issue Type: Improvement
> Reporter: Shaohui Liu
> Assignee: Shaohui Liu
> Priority: Minor
>
> When the global dict is too large than the spark executor memory, there will
> be too many dict slice evictions and loads in AppendTrieDictionary, and the
> build job will be very slow.
> It's better to throw an exception in advance in this case.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
