weibin0516 commented on a change in pull request #902: KYLIN-3832 Query
pushdown support postgresql
URL: https://github.com/apache/kylin/pull/902#discussion_r341467910
##########
File path:
source-jdbc/src/main/java/org/apache/kylin/source/jdbc/extensible/JdbcHiveInputBase.java
##########
@@ -57,6 +58,9 @@ protected AbstractExecutable
createSqoopToFlatHiveStep(String jobWorkingDir, Str
KylinConfig config = flatDesc.getDataModel().getConfig();
PartitionDesc partitionDesc =
flatDesc.getDataModel().getPartitionDesc();
String partCol = null;
+ boolean enableQuote =
dataSource.getSqlConverter().getConfigurer().enableQuote();
+ SqlDialect sqlDialect = enableQuote ?
dataSource.getSqlConverter().getConfigurer().getSqlDialect():
FlatTableSqlQuoteUtils.NON_QUOTE_DIALECT;
+ SqlConverter.IConfigurer iconfigurer =
dataSource.getSqlConverter().getConfigurer();
Review comment:
`IConfigurer config = dataSource.getSqlConverter().getConfigurer()` and
reuse config to avoid unnecessary temporary variables and make code clean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
