codecov-io edited a comment on issue #946: KYLIN-4259 fix potential NPE bug reported by FindBugs URL: https://github.com/apache/kylin/pull/946#issuecomment-554854347 # [Codecov](https://codecov.io/gh/apache/kylin/pull/946?src=pr&el=h1) Report > Merging [#946](https://codecov.io/gh/apache/kylin/pull/946?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/6b853ceda852c92c4b3e884426be6b34e3c62e0d?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/946?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #946 +/- ## ============================================ - Coverage 25.58% 25.57% -0.01% + Complexity 6140 6138 -2 ============================================ Files 1412 1412 Lines 85072 85073 +1 Branches 11928 11927 -1 ============================================ - Hits 21762 21754 -8 - Misses 61205 61211 +6 - Partials 2105 2108 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/946?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...e/kylin/rest/controller/StreamingV2Controller.java](https://codecov.io/gh/apache/kylin/pull/946/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9TdHJlYW1pbmdWMkNvbnRyb2xsZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../kylin/engine/mr/common/CuboidStatsReaderUtil.java](https://codecov.io/gh/apache/kylin/pull/946/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0N1Ym9pZFN0YXRzUmVhZGVyVXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../main/java/org/apache/kylin/common/StorageURL.java](https://codecov.io/gh/apache/kylin/pull/946/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9TdG9yYWdlVVJMLmphdmE=) | `64.63% <0%> (ø)` | `20 <0> (ø)` | :arrow_down: | | [...org/apache/kylin/metadata/model/PartitionDesc.java](https://codecov.io/gh/apache/kylin/pull/946/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvUGFydGl0aW9uRGVzYy5qYXZh) | `65.24% <0%> (ø)` | `18 <0> (ø)` | :arrow_down: | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/946/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | | | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/946/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0%> (-4.77%)` | `5% <0%> (-1%)` | | | [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/946/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0%> (-2.33%)` | `12% <0%> (ø)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/946/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | | | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/946/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | | | [...core/storage/columnar/GeneralColumnDataReader.java](https://codecov.io/gh/apache/kylin/pull/946/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvR2VuZXJhbENvbHVtbkRhdGFSZWFkZXIuamF2YQ==) | `94.73% <0%> (+5.26%)` | `7% <0%> (+1%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/946?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/946?src=pr&el=footer). Last update [6b853ce...d3e5940](https://codecov.io/gh/apache/kylin/pull/946?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
