nichunen commented on a change in pull request #973: [KYLIN-4165] Fix RT OLAP
building job on "Save Cube Dictionaries" step concurrency error
URL: https://github.com/apache/kylin/pull/973#discussion_r353579108
##########
File path:
engine-mr/src/main/java/org/apache/kylin/engine/mr/common/MapReduceExecutable.java
##########
@@ -186,14 +237,31 @@ protected ExecuteResult doWork(ExecutableContext
context) throws ExecuteExceptio
}
if (isDiscarded()) {
+ if (getIsNeedLock()) {
+ releaseLock(lock);
+ }
return new ExecuteResult(ExecuteResult.State.DISCARDED,
output.toString());
} else {
return new ExecuteResult(ExecuteResult.State.STOPPED,
output.toString());
}
} catch (ReflectiveOperationException e) {
logger.error("error getMapReduceJobClass, class name:" +
getParam(KEY_MR_JOB), e);
- return ExecuteResult.createError(e);
+ if (isDiscarded()) {
+ if (getIsNeedLock()) {
+ releaseLock(lock);
+ }
+ return new ExecuteResult(ExecuteResult.State.DISCARDED,
e.getMessage());
+ } else {
+ if (isDiscarded()) {
Review comment:
It can not be discarded here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
