sanjulian commented on a change in pull request #864: KYLIN-4181 Schedule Kylin using Kubernetes URL: https://github.com/apache/kylin/pull/864#discussion_r363649647
########## File path: kubernetes/Dockerfile ########## @@ -0,0 +1,63 @@ +FROM centos:centos7 + +ENV CDH_VERSION 5.7.6 +ENV JAVA_VERSION 1.8.0 Review comment: Hi @TempleZhou, how about split docker image as 2 part: one is base image, and the other is kylin image. Kylin docker image base on base image (hadoop-client image) by 'FROM'. And we can also provide 2 base image: one is apache version, the other is CDH version. It will benefit users who owns different version of hadoop version for their environment. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
