codecov-io edited a comment on issue #1053: minor, add some ut for dictionaries URL: https://github.com/apache/kylin/pull/1053#issuecomment-573369806 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1053?src=pr&el=h1) Report > Merging [#1053](https://codecov.io/gh/apache/kylin/pull/1053?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/b3884a11353a1a2ebabe0b9bed600b24110fe5eb?src=pr&el=desc) will **increase** coverage by `0.06%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/1053?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1053 +/- ## ============================================ + Coverage 25% 25.06% +0.06% - Complexity 6179 6222 +43 ============================================ Files 1438 1438 Lines 87669 87669 Branches 12256 12256 ============================================ + Hits 21919 21977 +58 + Misses 63597 63544 -53 + Partials 2153 2148 -5 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1053?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../java/org/apache/kylin/dict/TimeStrDictionary.java](https://codecov.io/gh/apache/kylin/pull/1053/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L1RpbWVTdHJEaWN0aW9uYXJ5LmphdmE=) | `92.3% <ø> (+46.15%)` | `17 <0> (+9)` | :arrow_up: | | [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1053/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0%> (-2.33%)` | `12% <0%> (ø)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1053/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1053/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.6% <0%> (+0.3%)` | `7% <0%> (ø)` | :arrow_down: | | [...ain/java/org/apache/kylin/dict/TrieDictionary.java](https://codecov.io/gh/apache/kylin/pull/1053/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L1RyaWVEaWN0aW9uYXJ5LmphdmE=) | `73.02% <0%> (+0.46%)` | `57% <0%> (+1%)` | :arrow_up: | | [...core/storage/columnar/GeneralColumnDataReader.java](https://codecov.io/gh/apache/kylin/pull/1053/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvR2VuZXJhbENvbHVtbkRhdGFSZWFkZXIuamF2YQ==) | `94.73% <0%> (+5.26%)` | `7% <0%> (+1%)` | :arrow_up: | | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1053/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `78.37% <0%> (+5.4%)` | `7% <0%> (+1%)` | :arrow_up: | | [...va/org/apache/kylin/dict/AppendTrieDictionary.java](https://codecov.io/gh/apache/kylin/pull/1053/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L0FwcGVuZFRyaWVEaWN0aW9uYXJ5LmphdmE=) | `78.09% <0%> (+10.47%)` | `28% <0%> (+9%)` | :arrow_up: | | [...java/org/apache/kylin/dict/ShrunkenDictionary.java](https://codecov.io/gh/apache/kylin/pull/1053/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L1NocnVua2VuRGljdGlvbmFyeS5qYXZh) | `92.98% <0%> (+22.8%)` | `16% <0%> (+9%)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/apache/kylin/pull/1053/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1053?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1053?src=pr&el=footer). Last update [b3884a1...876c919](https://codecov.io/gh/apache/kylin/pull/1053?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
