[
https://issues.apache.org/jira/browse/KYLIN-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013687#comment-17013687
]
ASF subversion and git services commented on KYLIN-4331:
--------------------------------------------------------
Commit 2a9aa87bb3833f80c29d462e5a1cd8c7a238b21e in kylin's branch
refs/heads/master from etherge
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=2a9aa87 ]
KYLIN-4331 Fix noncompliant method names in child class
> Follow compliant rules in Sonar
> -------------------------------
>
> Key: KYLIN-4331
> URL: https://issues.apache.org/jira/browse/KYLIN-4331
> Project: Kylin
> Issue Type: Improvement
> Reporter: Kaige Liu
> Assignee: Kaige Liu
> Priority: Minor
>
> When a method in a child class has the same signature as a method in a parent
> class, it is assumed to be an override. However, that's not the case when:
> * the parent class method is {{static}} and the child class method is not.
> * the arguments or return types of the child method are in different
> packages than those of the parent method.
> * the parent class method is {{private}}.
> Typically, these things are done unintentionally; the private parent class
> method is overlooked, the {{static}} keyword in the parent declaration is
> overlooked, or the wrong class is imported in the child. But if the intent is
> truly for the child class method to be different, then the method should be
> renamed to prevent confusion.
>
> [https://sonarcloud.io/project/issues?id=org.apache.kylin%3Akylin&issues=AWP9sMDe3e-qcckjAB5V&open=AWP9sMDe3e-qcckjAB5V]
> [https://sonarcloud.io/project/issues?id=org.apache.kylin%3Akylin&issues=AWcaThjuH5xombRgErVV&open=AWcaThjuH5xombRgErVV]
> [https://sonarcloud.io/project/issues?id=org.apache.kylin%3Akylin&issues=AWxmA253_Xcr_PhA6-Br&open=AWxmA253_Xcr_PhA6-Br]
> [https://sonarcloud.io/project/issues?id=org.apache.kylin%3Akylin&issues=AWxmA253_Xcr_PhA6-Bw&open=AWxmA253_Xcr_PhA6-Bw]
> [https://sonarcloud.io/project/issues?id=org.apache.kylin%3Akylin&issues=AWxmA253_Xcr_PhA6-By&open=AWxmA253_Xcr_PhA6-By]
> [https://sonarcloud.io/project/issues?id=org.apache.kylin%3Akylin&issues=AWxmA253_Xcr_PhA6-B1&open=AWxmA253_Xcr_PhA6-B1]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
