hit-lacus commented on a change in pull request #1054: Fix some insecure issues
URL: https://github.com/apache/kylin/pull/1054#discussion_r365655230
##########
File path:
core-common/src/main/java/org/apache/kylin/common/persistence/JDBCResourceStore.java
##########
@@ -44,28 +45,17 @@
public class JDBCResourceStore extends PushdownResourceStore {
- private static Logger logger =
LoggerFactory.getLogger(JDBCResourceStore.class);
-
public static final String JDBC_SCHEME = "jdbc";
-
+ private static final ConcurrentHashMap<String, Object> resourceHashMap =
new ConcurrentHashMap<>();
Review comment:
Maybe change the name `resourceHashMap` to something like `lockObjectMap` is
more readable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
