nichunen commented on a change in pull request #1056: KYLIN-4336 Global domain
dict for MR build engine
URL: https://github.com/apache/kylin/pull/1056#discussion_r374521549
##########
File path: core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java
##########
@@ -1375,12 +1376,37 @@ public void setParentForward(int parentForward) {
result.remove(dictDesc.getColumnRef());
result.add(dictDesc.getResuseColumnRef());
}
+
+ //tiretree global domain dic
+ if (Objects.isNull(dictDesc.getResuseColumnRef()) &&
Objects.nonNull(dictDesc.getReuseColumn())) {
+ logger.info("tiretree global domain dic : column {} use
tiretree global domain dic, reuse column {} ", dictDesc.getColumnRef(),
dictDesc.getReuseColumn());
Review comment:
I think it's better to put this into the scope of the previous conditional
expression "if (dictDesc.getResuseColumnRef() != null) "
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
