harveyyue opened a new pull request #1154: KYLIN-3847 Flink cubing step : fact distinct URL: https://github.com/apache/kylin/pull/1154 Refer jira: https://issues.apache.org/jira/browse/KYLIN-3847 Add flink fact distinct columns step, to avoid a mass of duplicated code with Spark and Flink implement self fact distinct step, add base class FactDistinctColumnsBase, extract core methods and variables from mapper/reducer class. About different engine will implement the abstract method FactDistinctColumnsBase.Visitor.collect(...) to output the result from Spark/Flink engine framework. Please help to review this code changes
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
