shaofengshi commented on a change in pull request #1152: KYLIN-4413: add canary
tool
URL: https://github.com/apache/kylin/pull/1152#discussion_r390772799
##########
File path:
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
##########
@@ -2475,4 +2475,21 @@ public int getStaleJobThresholdInDays() {
public String getIntersectFilterOrSeparator() {
return getOptional("kylin.query.intersect.separator", "|");
}
+
+ public String getCanarySinkClass() {
+ return getOptional("kylin.canary.sink.class",
"org.apache.kylin.tool.KylinCanary$StdOutSink");
+ }
+
+ public boolean isCanaryDaemon() {
+ return Boolean.parseBoolean(getOptional("kylin.canary.daemon", FALSE));
+ }
+
+ public long getCanaryInterval() {
+ return Long.parseLong(getOptional("kylin.canary.interval", "6000"));
+ }
+
+ public String getCanaryToken() {
+ return getOptional("kylin.canary.token", "");
Review comment:
Keep the basic auth in configuration file will increase the credential
exposure risk. Is there a better way to do the authentication?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
