[ 
https://issues.apache.org/jira/browse/KYLIN-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ChangjiGuo updated KYLIN-4433:
------------------------------
    Description: 
Hi guys :

    In the _Configuration overrides_ step of _Cube Designer_, I added the 
following configuration:
{code:java}
kylin.engine.mr.build-uhc-dict-in-additional-step = true
{code}
    When building the cube, it will take an extra step to handle the UHC 
dimensions, but I found that in the step of 'Build Dimension Dictionary', it 
still builds the dictionary that has been built in the previous step which 
takes double the time to build the dictionary.

    When I traced the source code, I found that our expected code was not 
executed due to _config.isBuildUHCDictWithMREnabled() == false_ :
{code:java}
if (config.isBuildUHCDictWithMREnabled() && uhcColumns.contains(col)) {
    colDir = new Path(dictPath, col.getIdentity());
} else {
    colDir = new Path(factColumnsInputPath, col.getIdentity());
}
{code}
    The root cause is that the configuration used in this step is the 
environment configuration, but our parameters are set in the cube:
{code:java}
final KylinConfig config = KylinConfig.getInstanceFromEnv();{code}
    I think the configuration of the cube should be used here instead of the 
environment configuration.

  was:
Hi guys :

    In the _Configuration overrides_ step of _Cube Designer_, I added the 
following configuration:
{code:java}
kylin.engine.mr.build-uhc-dict-in-additional-step = true
{code}
    When building the cube, it will take an extra step to handle the UHC 
dimensions, but I found that in the step of 'Build Dimension Dictionary', it 
still builds the dictionary that has been built in the previous step which 
takes double the time to build the dictionary.

    When I traced the source code, I found that our expected code was not 
executed due to _config.isBuildUHCDictWithMREnabled() == false_ :
{code:java}
if (config.isBuildUHCDictWithMREnabled() && uhcColumns.contains(col)) {
    colDir = new Path(dictPath, col.getIdentity());
} else {
    colDir = new Path(factColumnsInputPath, col.getIdentity());
}
{code}
    The root cause is that the configuration used in this step is the 
environment configuration, but our parameters are set in the cube:
{code:java}
final KylinConfig config = KylinConfig.getInstanceFromEnv();{code}


> When uhc step is turned on, Build Dimension Dictionary job cannot get correct 
> configuration
> -------------------------------------------------------------------------------------------
>
>                 Key: KYLIN-4433
>                 URL: https://issues.apache.org/jira/browse/KYLIN-4433
>             Project: Kylin
>          Issue Type: Bug
>          Components: Job Engine
>    Affects Versions: v2.6.4
>            Reporter: ChangjiGuo
>            Priority: Major
>
> Hi guys :
>     In the _Configuration overrides_ step of _Cube Designer_, I added the 
> following configuration:
> {code:java}
> kylin.engine.mr.build-uhc-dict-in-additional-step = true
> {code}
>     When building the cube, it will take an extra step to handle the UHC 
> dimensions, but I found that in the step of 'Build Dimension Dictionary', it 
> still builds the dictionary that has been built in the previous step which 
> takes double the time to build the dictionary.
>     When I traced the source code, I found that our expected code was not 
> executed due to _config.isBuildUHCDictWithMREnabled() == false_ :
> {code:java}
> if (config.isBuildUHCDictWithMREnabled() && uhcColumns.contains(col)) {
>     colDir = new Path(dictPath, col.getIdentity());
> } else {
>     colDir = new Path(factColumnsInputPath, col.getIdentity());
> }
> {code}
>     The root cause is that the configuration used in this step is the 
> environment configuration, but our parameters are set in the cube:
> {code:java}
> final KylinConfig config = KylinConfig.getInstanceFromEnv();{code}
>     I think the configuration of the cube should be used here instead of the 
> environment configuration.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to