[
https://issues.apache.org/jira/browse/KYLIN-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111662#comment-17111662
]
ASF GitHub Bot commented on KYLIN-2971:
---------------------------------------
codecov-commenter commented on pull request #1215:
URL: https://github.com/apache/kylin/pull/1215#issuecomment-631180807
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1215?src=pr&el=h1) Report
> Merging
[#1215](https://codecov.io/gh/apache/kylin/pull/1215?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/kylin/commit/7886a2498178ded085497d6204b4b367f56ce0c8&el=desc)
will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/kylin/pull/1215?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1215 +/- ##
============================================
- Coverage 24.85% 24.84% -0.02%
+ Complexity 6266 6263 -3
============================================
Files 1453 1453
Lines 89225 89236 +11
Branches 12456 12458 +2
============================================
- Hits 22175 22168 -7
- Misses 64874 64888 +14
- Partials 2176 2180 +4
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/1215?src=pr&el=tree) | Coverage
Δ | Complexity Δ | |
|---|---|---|---|
|
[...va/org/apache/kylin/rest/service/QueryService.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9RdWVyeVNlcnZpY2UuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==)
| `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | |
|
[...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==)
| `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | |
|
[.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=)
| `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | |
|
[...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=)
| `50.00% <0.00%> (-2.28%)` | `7.00% <0.00%> (-1.00%)` | |
|
[...ain/java/org/apache/kylin/dict/TrieDictionary.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L1RyaWVEaWN0aW9uYXJ5LmphdmE=)
| `72.55% <0.00%> (-0.47%)` | `56.00% <0.00%> (-1.00%)` | |
|
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
| `69.60% <0.00%> (+0.30%)` | `7.00% <0.00%> (ø%)` | |
|
[...core/storage/columnar/GeneralColumnDataReader.java](https://codecov.io/gh/apache/kylin/pull/1215/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvR2VuZXJhbENvbHVtbkRhdGFSZWFkZXIuamF2YQ==)
| `94.73% <0.00%> (+5.26%)` | `7.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/1215?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/1215?src=pr&el=footer). Last
update
[7886a24...87cd508](https://codecov.io/gh/apache/kylin/pull/1215?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix the wrong "Realization Names" in logQuery when hit cache
> ------------------------------------------------------------
>
> Key: KYLIN-2971
> URL: https://issues.apache.org/jira/browse/KYLIN-2971
> Project: Kylin
> Issue Type: Bug
> Reporter: Zhong Yanghong
> Assignee: Zhichao Zhang
> Priority: Minor
> Fix For: v3.1.0
>
> Attachments: APACHE-KYLIN-2971.patch
>
>
> # The value of "Realization Names" in logQuery is wrong when query two
> different sqls within the same thread and second sql hits cache:
> Example:
> 1). query Q1 hit project P1 and cube C1;
> 2). query Q2 hit project P2 and cube C2 in the same thread with Q1;
> 3). Q1 comes again and hits cache, it will show project P1 and
> {color:#f79232}cube C2{color}. However, it should be {color:#f79232}cube
> C1{color}.
> # Missing "Cuboid Ids" in logQuery when hit cache in a new thread which does
> not have OLAPContext;
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
