[
https://issues.apache.org/jira/browse/KYLIN-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17115677#comment-17115677
]
ASF GitHub Bot commented on KYLIN-4281:
---------------------------------------
codecov-commenter commented on pull request #1144:
URL: https://github.com/apache/kylin/pull/1144#issuecomment-633369840
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1144?src=pr&el=h1) Report
> Merging
[#1144](https://codecov.io/gh/apache/kylin/pull/1144?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/kylin/commit/178c7377d39b004144e54b1c931c92be82fe76de&el=desc)
will **increase** coverage by `0.01%`.
> The diff coverage is `23.60%`.
[](https://codecov.io/gh/apache/kylin/pull/1144?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1144 +/- ##
============================================
+ Coverage 25.91% 25.92% +0.01%
- Complexity 6521 6595 +74
============================================
Files 1456 1475 +19
Lines 89459 90159 +700
Branches 12482 12578 +96
============================================
+ Hits 23179 23371 +192
- Misses 64022 64516 +494
- Partials 2258 2272 +14
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/1144?src=pr&el=tree) | Coverage
Δ | Complexity Δ | |
|---|---|---|---|
|
[...a/org/apache/kylin/cube/CubeCapabilityChecker.java](https://codecov.io/gh/apache/kylin/pull/1144/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVDYXBhYmlsaXR5Q2hlY2tlci5qYXZh)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...in/java/org/apache/kylin/cube/CubeDescManager.java](https://codecov.io/gh/apache/kylin/pull/1144/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVEZXNjTWFuYWdlci5qYXZh)
| `33.57% <0.00%> (-0.25%)` | `12.00 <0.00> (ø)` | |
|
[...c/main/java/org/apache/kylin/cube/CubeSegment.java](https://codecov.io/gh/apache/kylin/pull/1144/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVTZWdtZW50LmphdmE=)
| `48.52% <0.00%> (-0.42%)` | `65.00 <0.00> (ø)` | |
|
[...kylin/cube/gridtable/CuboidToGridTableMapping.java](https://codecov.io/gh/apache/kylin/pull/1144/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2dyaWR0YWJsZS9DdWJvaWRUb0dyaWRUYWJsZU1hcHBpbmcuamF2YQ==)
| `45.13% <ø> (ø)` | `17.00 <0.00> (ø)` | |
|
[...in/cube/gridtable/CuboidToGridTableMappingExt.java](https://codecov.io/gh/apache/kylin/pull/1144/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2dyaWR0YWJsZS9DdWJvaWRUb0dyaWRUYWJsZU1hcHBpbmdFeHQuamF2YQ==)
| `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
|
[...che/kylin/cube/gridtable/ScanRangePlannerBase.java](https://codecov.io/gh/apache/kylin/pull/1144/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2dyaWR0YWJsZS9TY2FuUmFuZ2VQbGFubmVyQmFzZS5qYXZh)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1144/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=)
| `62.29% <0.00%> (-1.52%)` | `182.00 <0.00> (ø)` | |
|
[...va/org/apache/kylin/cube/util/KeyValueBuilder.java](https://codecov.io/gh/apache/kylin/pull/1144/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL3V0aWwvS2V5VmFsdWVCdWlsZGVyLmphdmE=)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...e/kylin/gridtable/GTAggregateTransformScanner.java](https://codecov.io/gh/apache/kylin/pull/1144/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9ncmlkdGFibGUvR1RBZ2dyZWdhdGVUcmFuc2Zvcm1TY2FubmVyLmphdmE=)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
|
[.../org/apache/kylin/gridtable/GTFunctionScanner.java](https://codecov.io/gh/apache/kylin/pull/1144/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9ncmlkdGFibGUvR1RGdW5jdGlvblNjYW5uZXIuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [80
more](https://codecov.io/gh/apache/kylin/pull/1144/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/1144?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/1144?src=pr&el=footer). Last
update
[178c737...bd0964f](https://codecov.io/gh/apache/kylin/pull/1144?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Precisely set the data type of tuple expression
> -----------------------------------------------
>
> Key: KYLIN-4281
> URL: https://issues.apache.org/jira/browse/KYLIN-4281
> Project: Kylin
> Issue Type: Improvement
> Reporter: Zhong Yanghong
> Assignee: Zhong Yanghong
> Priority: Major
> Fix For: v3.1.0
>
>
> Previously to simplify the calculating of sum(case when), all of the binary
> calculation is based on BigDecimal, which is not good for all, especially
> when dealing with count(distinct case when), whose inner data type may be hll
> or bitmap.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
