[
https://issues.apache.org/jira/browse/KYLIN-4520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117363#comment-17117363
]
ASF GitHub Bot commented on KYLIN-4520:
---------------------------------------
codecov-commenter commented on pull request #1230:
URL: https://github.com/apache/kylin/pull/1230#issuecomment-633800361
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1230?src=pr&el=h1) Report
> Merging
[#1230](https://codecov.io/gh/apache/kylin/pull/1230?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/kylin/commit/a11cdb58e68b49b224a9495a63c49101a3083a54&el=desc)
will **increase** coverage by `1.07%`.
> The diff coverage is `26.66%`.
[](https://codecov.io/gh/apache/kylin/pull/1230?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1230 +/- ##
============================================
+ Coverage 24.84% 25.91% +1.07%
- Complexity 6263 6596 +333
============================================
Files 1453 1475 +22
Lines 89225 90166 +941
Branches 12456 12580 +124
============================================
+ Hits 22166 23370 +1204
+ Misses 64879 64523 -356
- Partials 2180 2273 +93
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/1230?src=pr&el=tree) | Coverage
Δ | Complexity Δ | |
|---|---|---|---|
|
[.../cachemanager/InstrumentedEhCacheCacheManager.java](https://codecov.io/gh/apache/kylin/pull/1230/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL2NhY2hlbWFuYWdlci9JbnN0cnVtZW50ZWRFaENhY2hlQ2FjaGVNYW5hZ2VyLmphdmE=)
| `57.14% <ø> (ø)` | `5.00 <0.00> (ø)` | |
|
[...ylin/cache/cachemanager/MemcachedCacheManager.java](https://codecov.io/gh/apache/kylin/pull/1230/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL2NhY2hlbWFuYWdlci9NZW1jYWNoZWRDYWNoZU1hbmFnZXIuamF2YQ==)
| `43.33% <ø> (ø)` | `7.00 <0.00> (ø)` | |
|
[.../cachemanager/RemoteLocalFailOverCacheManager.java](https://codecov.io/gh/apache/kylin/pull/1230/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL2NhY2hlbWFuYWdlci9SZW1vdGVMb2NhbEZhaWxPdmVyQ2FjaGVNYW5hZ2VyLmphdmE=)
| `84.61% <ø> (ø)` | `7.00 <0.00> (ø)` | |
|
[...g/apache/kylin/cache/memcached/MemcachedCache.java](https://codecov.io/gh/apache/kylin/pull/1230/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL21lbWNhY2hlZC9NZW1jYWNoZWRDYWNoZS5qYXZh)
| `47.20% <ø> (ø)` | `20.00 <0.00> (ø)` | |
|
[.../kylin/cache/memcached/MemcachedChunkingCache.java](https://codecov.io/gh/apache/kylin/pull/1230/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL21lbWNhY2hlZC9NZW1jYWNoZWRDaHVua2luZ0NhY2hlLmphdmE=)
| `39.70% <ø> (-0.45%)` | `15.00 <0.00> (ø)` | |
|
[...apache/kylin/cache/memcached/MemcachedMetrics.java](https://codecov.io/gh/apache/kylin/pull/1230/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL21lbWNhY2hlZC9NZW1jYWNoZWRNZXRyaWNzLmphdmE=)
| `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
|
[...ache/kylin/common/BackwardCompatibilityConfig.java](https://codecov.io/gh/apache/kylin/pull/1230/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9CYWNrd2FyZENvbXBhdGliaWxpdHlDb25maWcuamF2YQ==)
| `41.81% <ø> (ø)` | `15.00 <0.00> (ø)` | |
|
[...main/java/org/apache/kylin/common/KylinConfig.java](https://codecov.io/gh/apache/kylin/pull/1230/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZy5qYXZh)
| `40.37% <ø> (ø)` | `28.00 <0.00> (ø)` | |
|
[.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1230/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==)
| `12.12% <ø> (ø)` | `44.00 <0.00> (ø)` | |
|
[...ain/java/org/apache/kylin/common/KylinVersion.java](https://codecov.io/gh/apache/kylin/pull/1230/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpblZlcnNpb24uamF2YQ==)
| `35.06% <ø> (ø)` | `11.00 <0.00> (ø)` | |
| ... and [349
more](https://codecov.io/gh/apache/kylin/pull/1230/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/1230?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/1230?src=pr&el=footer). Last
update
[dfd0af7...5ff273e](https://codecov.io/gh/apache/kylin/pull/1230?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve StorageCleanJobHbaseUtil to cleanup HBase tables in parallel
> --------------------------------------------------------------------
>
> Key: KYLIN-4520
> URL: https://issues.apache.org/jira/browse/KYLIN-4520
> Project: Kylin
> Issue Type: Improvement
> Components: Tools, Build and Test
> Reporter: Shao Feng Shi
> Assignee: Shao Feng Shi
> Priority: Major
> Fix For: v3.1.0
>
>
> The current StorageCleanJobHbaseUtil supports multi-threads, while from the
> execution logs, it still check one by one, so not really multi-threading.
>
> Below is the logs that use 5 threads " -- thread 5":
>
> {code:java}
> // code placeholder
> 2020-05-23 02:02:26,538 INFO [main] job.StorageCleanJobHbaseUtil:114 : Use 5
> threads to drop unused hbase tables
> 2020-05-23 02:02:26,539 INFO [pool-5-thread-1]
> job.StorageCleanJobHbaseUtil:171 : Deleting HBase table KYLIN_56XU9WDLOZ
> 2020-05-23 02:02:26,562 INFO [pool-5-thread-1]
> job.StorageCleanJobHbaseUtil:180 : HBase tableKYLIN_56XU9WDLOZ does not exist
> 2020-05-23 02:02:26,564 INFO [pool-5-thread-2]
> job.StorageCleanJobHbaseUtil:171 : Deleting HBase table KYLIN_590IHJ5QTM
> 2020-05-23 02:02:26,576 INFO [pool-5-thread-2]
> job.StorageCleanJobHbaseUtil:180 : HBase tableKYLIN_590IHJ5QTM does not exist
> 2020-05-23 02:02:26,577 INFO [pool-5-thread-3]
> job.StorageCleanJobHbaseUtil:171 : Deleting HBase table KYLIN_7U8J7ZFBYN
> 2020-05-23 02:02:26,586 INFO [pool-5-thread-3]
> job.StorageCleanJobHbaseUtil:180 : HBase tableKYLIN_7U8J7ZFBYN does not exist
> 2020-05-23 02:02:26,587 INFO [pool-5-thread-4]
> job.StorageCleanJobHbaseUtil:171 : Deleting HBase table KYLIN_BOR03PP4PV
> 2020-05-23 02:02:26,595 INFO [pool-5-thread-4]
> job.StorageCleanJobHbaseUtil:180 : HBase tableKYLIN_BOR03PP4PV does not exist
> 2020-05-23 02:02:26,596 INFO [pool-5-thread-5]
> job.StorageCleanJobHbaseUtil:171 : Deleting HBase table KYLIN_ESGGE02OQI
> 2020-05-23 02:02:26,606 INFO [pool-5-thread-5]
> job.StorageCleanJobHbaseUtil:180 : HBase tableKYLIN_ESGGE02OQI does not exist
> 2020-05-23 02:02:26,606 INFO [pool-5-thread-1]
> job.StorageCleanJobHbaseUtil:171 : Deleting HBase table KYLIN_FHWPLEOSO6
> 2020-05-23 02:02:26,617 INFO [pool-5-thread-1]
> job.StorageCleanJobHbaseUtil:180 : HBase tableKYLIN_FHWPLEOSO6 does not exist
> 2020-05-23 02:02:26,618 INFO [pool-5-thread-2]
> job.StorageCleanJobHbaseUtil:171 : Deleting HBase table KYLIN_GWYKX70W9A
> 2020-05-23 02:02:26,642 INFO [pool-5-thread-2] client.HBaseAdmin:1330 :
> Started disable of KYLIN_GWYKX70W9A
> 2020-05-23 02:02:30,802 INFO [pool-5-thread-2] client.HBaseAdmin:1357 :
> Disabled KYLIN_GWYKX70W9A
> 2020-05-23 02:02:32,094 INFO [pool-5-thread-2] client.HBaseAdmin:924 :
> Deleted KYLIN_GWYKX70W9A
> 2020-05-23 02:02:32,094 INFO [pool-5-thread-2]
> job.StorageCleanJobHbaseUtil:178 : Deleted HBase table KYLIN_GWYKX70W9A
> 2020-05-23 02:02:32,095 INFO [pool-5-thread-3]
> job.StorageCleanJobHbaseUtil:171 : Deleting HBase table KYLIN_HLB7508SUV
> 2020-05-23 02:02:32,113 INFO [pool-5-thread-3] client.HBaseAdmin:1330 :
> Started disable of KYLIN_HLB7508SUV
> 2020-05-23 02:02:34,348 INFO [pool-5-thread-3] client.HBaseAdmin:1357 :
> Disabled KYLIN_HLB7508SUV
> 2020-05-23 02:02:36,582 INFO [pool-5-thread-3] client.HBaseAdmin:924 :
> Deleted KYLIN_HLB7508SUV
> 2020-05-23 02:02:36,582 INFO [pool-5-thread-3]
> job.StorageCleanJobHbaseUtil:178 : Deleted HBase table KYLIN_HLB7508SUV
> 2020-05-23 02:02:36,582 INFO [pool-5-thread-4]
> job.StorageCleanJobHbaseUtil:171 : Deleting HBase table KYLIN_JPIJ7GT1F5
> 2020-05-23 02:02:36,599 INFO [pool-5-thread-4] client.HBaseAdmin:1330 :
> Started disable of KYLIN_JPIJ7GT1F5
> 2020-05-23 02:02:40,959 INFO [pool-5-thread-4] client.HBaseAdmin:1357 :
> Disabled KYLIN_JPIJ7GT1F5
> 2020-05-23 02:02:42,119 INFO [pool-5-thread-4] client.HBaseAdmin:924 :
> Deleted KYLIN_JPIJ7GT1F5
> 2020-05-23 02:02:42,119 INFO [pool-5-thread-4]
> job.StorageCleanJobHbaseUtil:178 : Deleted HBase table KYLIN_JPIJ7GT1F5
> 2020-05-23 02:02:42,119 INFO [pool-5-thread-5]
> job.StorageCleanJobHbaseUtil:171 : Deleting HBase table KYLIN_KV4U23OBEP
> 2020-05-23 02:02:42,141 INFO [pool-5-thread-5] client.HBaseAdmin:1330 :
> Started disable of KYLIN_KV4U23OBEP
> 2020-05-23 02:02:46,322 INFO [pool-5-thread-5] client.HBaseAdmin:1357 :
> Disabled KYLIN_KV4U23OBEP
> 2020-05-23 02:02:47,958 INFO [pool-5-thread-5] client.HBaseAdmin:924 :
> Deleted KYLIN_KV4U23OBEP
> 2020-05-23 02:02:47,958 INFO [pool-5-thread-5]
> job.StorageCleanJobHbaseUtil:178 : Deleted HBase table KYLIN_KV4U23OBEP
> 2020-05-23 02:02:47,958 INFO [pool-5-thread-1]
> job.StorageCleanJobHbaseUtil:171 : Deleting HBase table KYLIN_L802CS1ZZU
> 2020-05-23 02:02:47,975 INFO [pool-5-thread-1] client.HBaseAdmin:1330 :
> Started disable of KYLIN_L802CS1ZZU
> 2020-05-23 02:02:50,194 INFO [pool-5-thread-1] client.HBaseAdmin:1357 :
> Disabled KYLIN_L802CS1ZZU
> 2020-05-23 02:02:51,554 INFO [pool-5-thread-1] client.HBaseAdmin:924 :
> Deleted KYLIN_L802CS1ZZU
> 2020-05-23 02:02:51,555 INFO [pool-5-thread-1]
> job.StorageCleanJobHbaseUtil:178 : Deleted HBase table KYLIN_L802CS1ZZU
> 2020-05-23 02:02:51,555 INFO [pool-5-thread-2]
> job.StorageCleanJobHbaseUtil:171 : Deleting HBase table KYLIN_L9D9CZXZIG
> 2020-05-23 02:02:51,570 INFO [pool-5-thread-2] client.HBaseAdmin:1330 :
> Started disable of KYLIN_L9D9CZXZIG
> 2020-05-23 02:02:53,773 INFO [pool-5-thread-2] client.HBaseAdmin:1357 :
> Disabled KYLIN_L9D9CZXZIG
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
