[ 
https://issues.apache.org/jira/browse/KYLIN-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126070#comment-17126070
 ] 

ASF GitHub Bot commented on KYLIN-4352:
---------------------------------------

codecov-commenter commented on pull request #1241:
URL: https://github.com/apache/kylin/pull/1241#issuecomment-638976568


   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1241?src=pr&el=h1) Report
   > Merging 
[#1241](https://codecov.io/gh/apache/kylin/pull/1241?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/kylin/commit/5731f43fcf350247e76fd7e36b0980d5cf9fc912&el=desc)
 will **decrease** coverage by `0.03%`.
   > The diff coverage is `15.34%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/1241/graphs/tree.svg?width=650&height=150&src=pr&token=JawVgbgsVo)](https://codecov.io/gh/apache/kylin/pull/1241?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1241      +/-   ##
   ============================================
   - Coverage     25.75%   25.71%   -0.04%     
   - Complexity     6621     6625       +4     
   ============================================
     Files          1482     1484       +2     
     Lines         90949    91184     +235     
     Branches      12687    12726      +39     
   ============================================
   + Hits          23423    23448      +25     
   - Misses        65227    65433     +206     
   - Partials       2299     2303       +4     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/1241?src=pr&el=tree) | Coverage 
Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...in/java/org/apache/kylin/common/util/JsonUtil.java](https://codecov.io/gh/apache/kylin/pull/1241/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0pzb25VdGlsLmphdmE=)
 | `30.43% <ø> (-1.71%)` | `3.00 <0.00> (ø)` | |
   | 
[...he/kylin/sdk/datasource/adaptor/PrestoAdaptor.java](https://codecov.io/gh/apache/kylin/pull/1241/diff?src=pr&el=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2FkYXB0b3IvUHJlc3RvQWRhcHRvci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...k/datasource/framework/SourceConnectorFactory.java](https://codecov.io/gh/apache/kylin/pull/1241/diff?src=pr&el=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2ZyYW1ld29yay9Tb3VyY2VDb25uZWN0b3JGYWN0b3J5LmphdmE=)
 | `33.33% <0.00%> (-21.67%)` | `1.00 <1.00> (ø)` | |
   | 
[.../org/apache/kylin/query/util/PushDownExecutor.java](https://codecov.io/gh/apache/kylin/pull/1241/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUHVzaERvd25FeGVjdXRvci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...java/org/apache/kylin/query/util/PushDownUtil.java](https://codecov.io/gh/apache/kylin/pull/1241/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUHVzaERvd25VdGlsLmphdmE=)
 | `80.48% <0.00%> (ø)` | `4.00 <0.00> (ø)` | |
   | 
[...va/org/apache/kylin/rest/service/QueryService.java](https://codecov.io/gh/apache/kylin/pull/1241/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9RdWVyeVNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../apache/kylin/rest/service/StreamingV2Service.java](https://codecov.io/gh/apache/kylin/pull/1241/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9TdHJlYW1pbmdWMlNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...pache/kylin/storage/stream/StreamStorageQuery.java](https://codecov.io/gh/apache/kylin/pull/1241/diff?src=pr&el=tree#diff-c3RvcmFnZS1zdHJlYW0vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0b3JhZ2Uvc3RyZWFtL1N0cmVhbVN0b3JhZ2VRdWVyeS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...storage/stream/rpc/HttpStreamDataSearchClient.java](https://codecov.io/gh/apache/kylin/pull/1241/diff?src=pr&el=tree#diff-c3RvcmFnZS1zdHJlYW0vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0b3JhZ2Uvc3RyZWFtL3JwYy9IdHRwU3RyZWFtRGF0YVNlYXJjaENsaWVudC5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...rg/apache/kylin/stream/core/model/DataRequest.java](https://codecov.io/gh/apache/kylin/pull/1241/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL21vZGVsL0RhdGFSZXF1ZXN0LmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [13 
more](https://codecov.io/gh/apache/kylin/pull/1241/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/1241?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/1241?src=pr&el=footer). Last 
update 
[cef1093...fa41cf9](https://codecov.io/gh/apache/kylin/pull/1241?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> A empty segment will cause incomplete query result in Realtime OLAP
> -------------------------------------------------------------------
>
>                 Key: KYLIN-4352
>                 URL: https://issues.apache.org/jira/browse/KYLIN-4352
>             Project: Kylin
>          Issue Type: Bug
>          Components: Real-time Streaming
>    Affects Versions: v3.0.0
>            Reporter: Xiaoxiang Yu
>            Assignee: Xiaoxiang Yu
>            Priority: Major
>             Fix For: v3.1.0
>
>
> When you query hit a streaming cube, you query will divided into two part, 
> one historical part, one realtime part.
> The boundary of two part is decided by the latest READY segment's *End Time* 
> . But when you have a segment which segment range is from future(created by 
> mistake), it will cause all following query get incomplete result.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to