[
https://issues.apache.org/jira/browse/KYLIN-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134047#comment-17134047
]
ASF GitHub Bot commented on KYLIN-4485:
---------------------------------------
coveralls edited a comment on pull request #1218:
URL: https://github.com/apache/kylin/pull/1218#issuecomment-631287497
## Pull Request Test Coverage Report for [Build
6009](https://coveralls.io/builds/31410100)
* **359** of **2278** **(15.76%)** changed or added relevant lines in
**63** files are covered.
* **177** unchanged lines in **15** files lost coverage.
* Overall coverage decreased (**-0.3%**) to **27.916%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
|
[core-cube/src/main/java/org/apache/kylin/cube/model/RowKeyDesc.java](https://coveralls.io/builds/31410100/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FRowKeyDesc.java#L71)
| 0 | 1 | 0.0%
|
[core-dictionary/src/main/java/org/apache/kylin/dict/lookup/LookupStringTable.java](https://coveralls.io/builds/31410100/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2FLookupStringTable.java#L89)
| 3 | 4 | 75.0%
|
[core-metadata/src/main/java/org/apache/kylin/metadata/tuple/TupleInfo.java](https://coveralls.io/builds/31410100/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ftuple%2FTupleInfo.java#L56)
| 0 | 1 | 0.0%
|
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/HBaseResourceStore.java](https://coveralls.io/builds/31410100/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2FHBaseResourceStore.java#L100)
| 0 | 1 | 0.0%
|
[core-cube/src/main/java/org/apache/kylin/cube/model/RowKeyColDesc.java](https://coveralls.io/builds/31410100/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FRowKeyColDesc.java#L49)
| 3 | 5 | 60.0%
|
[core-job/src/main/java/org/apache/kylin/job/impl/curator/CuratorScheduler.java](https://coveralls.io/builds/31410100/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fcurator%2FCuratorScheduler.java#L85)
| 0 | 2 | 0.0%
|
[core-metadata/src/main/java/org/apache/kylin/metadata/model/TableDesc.java](https://coveralls.io/builds/31410100/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FTableDesc.java#L282)
| 6 | 8 | 75.0%
|
[cube-migration/src/main/java/org/apache/kylin/rest/util/MailNotificationUtil.java](https://coveralls.io/builds/31410100/source?filename=cube-migration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FMailNotificationUtil.java#L23)
| 0 | 2 | 0.0%
|
[tool/src/main/java/org/apache/kylin/tool/CubeMigrationCLI.java](https://coveralls.io/builds/31410100/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2FCubeMigrationCLI.java#L648)
| 0 | 2 | 0.0%
|
[core-metadata/src/main/java/org/apache/kylin/metadata/model/ParameterDesc.java](https://coveralls.io/builds/31410100/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FParameterDesc.java#L270)
| 0 | 3 | 0.0%
<!-- | **Total:** | **359** | **2278** | **15.76%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
|
[core-storage/src/main/java/org/apache/kylin/storage/gtrecord/CubeTupleConverter.java](https://coveralls.io/builds/31410100/source?filename=core-storage%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fgtrecord%2FCubeTupleConverter.java#L158)
| 1 | 0% |
|
[core-storage/src/main/java/org/apache/kylin/storage/translate/DerivedFilterTranslator.java](https://coveralls.io/builds/31410100/source?filename=core-storage%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Ftranslate%2FDerivedFilterTranslator.java#L79)
| 1 | 0% |
|
[server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java](https://coveralls.io/builds/31410100/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FCubeController.java#L1042)
| 1 | 0% |
|
[server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java](https://coveralls.io/builds/31410100/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FCubeService.java#L1106)
| 1 | 0% |
|
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/GeneralColumnDataReader.java](https://coveralls.io/builds/31410100/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FGeneralColumnDataReader.java#L43)
| 1 | 92.11% |
|
[core-common/src/main/java/org/apache/kylin/common/restclient/RestClient.java](https://coveralls.io/builds/31410100/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Frestclient%2FRestClient.java#L248)
| 2 | 17.8% |
|
[core-dictionary/src/main/java/org/apache/kylin/dict/TimeStrDictionary.java](https://coveralls.io/builds/31410100/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2FTimeStrDictionary.java#L115)
| 2 | 88.46% |
|
[server-base/src/main/java/org/apache/kylin/rest/service/TableSchemaUpdateChecker.java](https://coveralls.io/builds/31410100/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FTableSchemaUpdateChecker.java#L251)
| 4 | 0% |
|
[engine-spark/src/main/java/org/apache/kylin/engine/spark/KylinKryoRegistrator.java](https://coveralls.io/builds/31410100/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FKylinKryoRegistrator.java#L117)
| 6 | 0% |
|
[server-base/src/main/java/org/apache/kylin/rest/service/AdminService.java](https://coveralls.io/builds/31410100/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FAdminService.java#L106)
| 7 | 0% |
<!-- | **Total:** | **177** | | -->
| Totals | [](https://coveralls.io/builds/31410100)
|
| :-- | --: |
| Change from base [Build 6000](https://coveralls.io/builds/31367055): |
-0.3% |
| Covered Lines: | 26046 |
| Relevant Lines: | 93300 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Create a self service interface for cube migration
> --------------------------------------------------
>
> Key: KYLIN-4485
> URL: https://issues.apache.org/jira/browse/KYLIN-4485
> Project: Kylin
> Issue Type: New Feature
> Components: Tools, Build and Test
> Reporter: Zhong Yanghong
> Assignee: Zhong Yanghong
> Priority: Major
> Fix For: v3.1.0
>
> Attachments: cube-migration-new.png, cube-migration-old.png
>
>
> Current cube migration process is as follows:
> Â !cube-migration-old.png!
> There're a few drawbacks:
> * kylin admin has to manually check all related aspects to decide whether a
> cube is good for migration. If cube design is not good, there'll be many
> interaction between users & kylin admins
> * kylin admin has to login to the backend server and then run a command to
> do the migration, which is tricky and easy to make mistakes
> * there's little compatibility check between source metadata & destination
> cluster.
> A self service interface will refine the migration process as follows:
> !cube-migration-new.png!
> We can see with the new migration process, there'll be few interactions
> between users & kylin admins and much less work for kylin admins.
> Â
> *For this new feature, add some new properties*:
> * kylin.cube.migration.enabled
> Specifies whether to show 'Migrate', 'Approve Migration' and 'Reject
> Migration' in "Action" drop-down list for cube management, the default value
> is false;
> * kylin.metadata.model-schema-updater-checker-enabled
> Specifies whether to check for model schema update when check check model
> compatibility, the default value is false;
> * kylin.metadata.able-change-string-to-datetime
> Specifies whether to enable to convert String to Date or Time when check
> table schema update, the default value is false;
> * kylin.cube.rowkey-encoding-auto-convert
> Specifies whether to enable to convert date/time dictionary on
> date/time/varchar column to DimensionEncoding implicitly, the default value
> is true;
> * kylin.server.self-discovery-enabled
> Specifies whether to enable to discover kylin instance from zookeeper, the
> default value is false;
> * kylin.cube.migration.expansion-rate
> Specifies the threshold value of expansion rate when check the quality of the
> cube, the default value is 5;
> * kylin.cube.migration.query-generator-max-dimension-number
> Specifies the max number of dimension column when generate sql for checking
> the quality of the cube, the default value is 3;
> * kylin.cube.migration.rule-query-latency-enabled
> Specifies whether to check query latency when check the quality of the cube,
> the default value is true;
> * kylin.cube.migration.query-latency-seconds
> Specifies the threshold value of query latency in seconds when check the
> quality of the cube, the default value is 2;
> * kylin.cube.migration.query-latency-max-threads
> Specifies the max number of query threads to execute sql when check the
> quality of the cube, the default value is 5;
> * kylin.cube.migration.query-latency-iteration
> Specifies the max number of query sql to be generated when check the quality
> of the cube, the default value is 5;
> * kylin.cube.migration.source-address
> Specifies the source address of kylin instance;
> * kylin.cube.migration.target-address
> Specifies the target address of kylin instance;
> * kylin.cube.notification-mail-suffix
> Specifies the default suffix address of email for sending notifications.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
