[
https://issues.apache.org/jira/browse/KYLIN-4567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135649#comment-17135649
]
ASF GitHub Bot commented on KYLIN-4567:
---------------------------------------
codecov-commenter commented on pull request #1259:
URL: https://github.com/apache/kylin/pull/1259#issuecomment-644007274
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1259?src=pr&el=h1) Report
> Merging
[#1259](https://codecov.io/gh/apache/kylin/pull/1259?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/kylin/commit/12e4ad9786c6d6246c06731340f592f58325363e&el=desc)
will **decrease** coverage by `0.28%`.
> The diff coverage is `14.31%`.
[](https://codecov.io/gh/apache/kylin/pull/1259?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1259 +/- ##
============================================
- Coverage 25.71% 25.43% -0.29%
- Complexity 6626 6732 +106
============================================
Files 1484 1505 +21
Lines 91185 93324 +2139
Branches 12726 13086 +360
============================================
+ Hits 23452 23733 +281
- Misses 65431 67252 +1821
- Partials 2302 2339 +37
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/1259?src=pr&el=tree) | Coverage
Δ | Complexity Δ | |
|---|---|---|---|
|
[...main/java/org/apache/kylin/common/KylinConfig.java](https://codecov.io/gh/apache/kylin/pull/1259/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZy5qYXZh)
| `38.29% <0.00%> (-2.08%)` | `29.00 <0.00> (+1.00)` | :arrow_down: |
|
[.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1259/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==)
| `12.70% <0.00%> (+0.99%)` | `51.00 <0.00> (+7.00)` | |
|
[...org/apache/kylin/common/restclient/RestClient.java](https://codecov.io/gh/apache/kylin/pull/1259/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9yZXN0Y2xpZW50L1Jlc3RDbGllbnQuamF2YQ==)
| `15.25% <0.00%> (-3.11%)` | `6.00 <1.00> (ø)` | |
|
[...n/java/org/apache/kylin/common/util/CheckUtil.java](https://codecov.io/gh/apache/kylin/pull/1259/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0NoZWNrVXRpbC5qYXZh)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...c/main/java/org/apache/kylin/cube/CubeSegment.java](https://codecov.io/gh/apache/kylin/pull/1259/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVTZWdtZW50LmphdmE=)
| `42.27% <0.00%> (-6.25%)` | `65.00 <0.00> (ø)` | |
|
[...rg/apache/kylin/cube/gridtable/CubeCodeSystem.java](https://codecov.io/gh/apache/kylin/pull/1259/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2dyaWR0YWJsZS9DdWJlQ29kZVN5c3RlbS5qYXZh)
| `22.07% <0.00%> (-3.30%)` | `8.00 <0.00> (ø)` | |
|
[.../org/apache/kylin/cube/model/AggregationGroup.java](https://codecov.io/gh/apache/kylin/pull/1259/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0FnZ3JlZ2F0aW9uR3JvdXAuamF2YQ==)
| `77.15% <ø> (ø)` | `85.00 <0.00> (ø)` | |
|
[...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1259/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=)
| `58.15% <0.00%> (-4.14%)` | `182.00 <0.00> (ø)` | |
|
[...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://codecov.io/gh/apache/kylin/pull/1259/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=)
| `48.57% <0.00%> (-16.82%)` | `8.00 <0.00> (ø)` | |
|
[...apache/kylin/cube/model/HBaseColumnFamilyDesc.java](https://codecov.io/gh/apache/kylin/pull/1259/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0hCYXNlQ29sdW1uRmFtaWx5RGVzYy5qYXZh)
| `23.80% <0.00%> (-14.66%)` | `4.00 <0.00> (ø)` | |
| ... and [103
more](https://codecov.io/gh/apache/kylin/pull/1259/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/1259?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/1259?src=pr&el=footer). Last
update
[b5ef6dd...b145eb7](https://codecov.io/gh/apache/kylin/pull/1259?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve TopN merge performance in MR engine
> -------------------------------------------
>
> Key: KYLIN-4567
> URL: https://issues.apache.org/jira/browse/KYLIN-4567
> Project: Kylin
> Issue Type: Improvement
> Components: Measure - TopN
> Reporter: Guangxu Cheng
> Assignee: Guangxu Cheng
> Priority: Major
>
> We have a cube that needs to calculate the TOPN of 13 columns. The number of
> data source is only 500k. But, the cubing job always fail when building base
> cuboid.
> we found that the map task always killed by the ApplicationMaster due to time
> out
> {noformat}
> ERROR-[-10001]-[MR]:[Mr Task
> Timeout]:[AttemptID:attempt_1591996262448_229922_m_000000_1 Timed out after
> 3600 secs!] ERROR-[-10015]-[MR]:[Container Exit Accidentally]:[Container
> killed by the ApplicationMaster. Container killed on request. Exit code is
> 143 Container exited with a non-zero exit code 143 ]
> {noformat}
> the stack information as below:
> {noformat}
> "SpillThread" #35 daemon prio=5 os_prio=0 tid=0x00007f9a89771800 nid=0x133a2
> runnable [0x00007f9a56e3f000]
> java.lang.Thread.State: RUNNABLE
> at java.util.LinkedList.toArray(LinkedList.java:1052)
> at java.util.List.sort(List.java:477)
> at java.util.Collections.sort(Collections.java:175)
> at
> org.apache.kylin.measure.topn.TopNCounter.sortAndRetain(TopNCounter.java:96)
> at
> org.apache.kylin.measure.topn.TopNCounter.merge(TopNCounter.java:183)
> at
> org.apache.kylin.measure.topn.TopNAggregator.aggregate(TopNAggregator.java:44)
> at
> org.apache.kylin.measure.topn.TopNAggregator.aggregate(TopNAggregator.java:27)
> at
> org.apache.kylin.measure.MeasureAggregators.aggregate(MeasureAggregators.java:83)
> at
> org.apache.kylin.engine.mr.steps.CuboidReducer.doReduce(CuboidReducer.java:108)
> at
> org.apache.kylin.engine.mr.steps.CuboidReducer.doReduce(CuboidReducer.java:44)
> at
> org.apache.kylin.engine.mr.KylinReducer.reduce(KylinReducer.java:77)
> at org.apache.hadoop.mapreduce.Reducer.run(Reducer.java:171)
> at
> org.apache.hadoop.mapred.Task$NewCombinerRunner.combine(Task.java:1688)
> at
> org.apache.hadoop.mapred.MapTask$MapOutputBuffer.sortAndSpill(MapTask.java:1645)
> at
> org.apache.hadoop.mapred.MapTask$MapOutputBuffer.access$900(MapTask.java:884)
> at
> org.apache.hadoop.mapred.MapTask$MapOutputBuffer$SpillThread.run(MapTask.java:1540)
> {noformat}
> From the stack information, we found that sorting takes a lot of time. After
> merge another counter into this counter, need to re-sort this counter. Maybe
> we can reduce the frequency of sorting
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
