[
https://issues.apache.org/jira/browse/KYLIN-4571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135736#comment-17135736
]
ASF GitHub Bot commented on KYLIN-4571:
---------------------------------------
codecov-commenter commented on pull request #1261:
URL: https://github.com/apache/kylin/pull/1261#issuecomment-644052980
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1261?src=pr&el=h1) Report
> Merging
[#1261](https://codecov.io/gh/apache/kylin/pull/1261?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/kylin/commit/faa15ad8b13f6ccf9161b6bb59af84f29b9bf958&el=desc)
will **decrease** coverage by `0.28%`.
> The diff coverage is `13.88%`.
[](https://codecov.io/gh/apache/kylin/pull/1261?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1261 +/- ##
============================================
- Coverage 25.75% 25.47% -0.29%
- Complexity 6638 6733 +95
============================================
Files 1484 1505 +21
Lines 91202 93307 +2105
Branches 12727 13082 +355
============================================
+ Hits 23487 23766 +279
- Misses 65414 67203 +1789
- Partials 2301 2338 +37
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/1261?src=pr&el=tree) | Coverage
Δ | Complexity Δ | |
|---|---|---|---|
|
[...main/java/org/apache/kylin/common/KylinConfig.java](https://codecov.io/gh/apache/kylin/pull/1261/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZy5qYXZh)
| `38.29% <0.00%> (-2.08%)` | `29.00 <0.00> (+1.00)` | :arrow_down: |
|
[.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1261/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==)
| `12.70% <0.00%> (+1.04%)` | `51.00 <0.00> (+7.00)` | |
|
[...org/apache/kylin/common/restclient/RestClient.java](https://codecov.io/gh/apache/kylin/pull/1261/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9yZXN0Y2xpZW50L1Jlc3RDbGllbnQuamF2YQ==)
| `15.25% <0.00%> (-3.11%)` | `6.00 <1.00> (ø)` | |
|
[...n/java/org/apache/kylin/common/util/CheckUtil.java](https://codecov.io/gh/apache/kylin/pull/1261/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0NoZWNrVXRpbC5qYXZh)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...c/main/java/org/apache/kylin/cube/CubeSegment.java](https://codecov.io/gh/apache/kylin/pull/1261/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVTZWdtZW50LmphdmE=)
| `42.27% <0.00%> (-6.25%)` | `65.00 <0.00> (ø)` | |
|
[...rg/apache/kylin/cube/gridtable/CubeCodeSystem.java](https://codecov.io/gh/apache/kylin/pull/1261/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2dyaWR0YWJsZS9DdWJlQ29kZVN5c3RlbS5qYXZh)
| `22.07% <0.00%> (-3.30%)` | `8.00 <0.00> (ø)` | |
|
[.../org/apache/kylin/cube/model/AggregationGroup.java](https://codecov.io/gh/apache/kylin/pull/1261/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0FnZ3JlZ2F0aW9uR3JvdXAuamF2YQ==)
| `77.15% <ø> (ø)` | `85.00 <0.00> (ø)` | |
|
[...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1261/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=)
| `58.15% <0.00%> (-4.14%)` | `182.00 <0.00> (ø)` | |
|
[...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://codecov.io/gh/apache/kylin/pull/1261/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=)
| `48.57% <0.00%> (-16.82%)` | `8.00 <0.00> (ø)` | |
|
[...apache/kylin/cube/model/HBaseColumnFamilyDesc.java](https://codecov.io/gh/apache/kylin/pull/1261/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0hCYXNlQ29sdW1uRmFtaWx5RGVzYy5qYXZh)
| `23.80% <0.00%> (-14.66%)` | `4.00 <0.00> (ø)` | |
| ... and [87
more](https://codecov.io/gh/apache/kylin/pull/1261/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/1261?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/1261?src=pr&el=footer). Last
update
[5a65eb2...99dbc90](https://codecov.io/gh/apache/kylin/pull/1261?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Always set GMT timezone for RecordEventTimeDetail
> -------------------------------------------------
>
> Key: KYLIN-4571
> URL: https://issues.apache.org/jira/browse/KYLIN-4571
> Project: Kylin
> Issue Type: Improvement
> Reporter: Zhong Yanghong
> Assignee: Zhong Yanghong
> Priority: Major
> Fix For: v3.1.0
>
>
> Since the config kylin.web.timezone may be changed by users overtime, the
> formatted time strings RecordEventTimeDetail may have incorrect meanings.
> It's better to always set the time zone to be GMT so that the formatted time
> strings will not be influenced by the change of kylin.web.timezone.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
