[
https://issues.apache.org/jira/browse/KYLIN-4616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150797#comment-17150797
]
ASF GitHub Bot commented on KYLIN-4616:
---------------------------------------
coveralls commented on pull request #1304:
URL: https://github.com/apache/kylin/pull/1304#issuecomment-653400443
## Pull Request Test Coverage Report for [Build
6098](https://coveralls.io/builds/31841907)
* **0** of **31** **(0.0%)** changed or added relevant lines in **9**
files are covered.
* **9** unchanged lines in **4** files lost coverage.
* Overall coverage increased (+**0.002%**) to **27.976%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
|
[core-cube/src/main/java/org/apache/kylin/cube/CubeSegment.java](https://coveralls.io/builds/31841907/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeSegment.java#L382)
| 0 | 1 | 0.0%
|
[engine-mr/src/main/java/org/apache/kylin/engine/mr/common/DictionaryGetterUtil.java](https://coveralls.io/builds/31841907/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fcommon%2FDictionaryGetterUtil.java#L58)
| 0 | 1 | 0.0%
|
[engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/BuildGlobalHiveDictPartBuildJob.java](https://coveralls.io/builds/31841907/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FBuildGlobalHiveDictPartBuildJob.java#L147)
| 0 | 1 | 0.0%
|
[engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/ExtractDictionaryFromGlobalMapper.java](https://coveralls.io/builds/31841907/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FExtractDictionaryFromGlobalMapper.java#L84)
| 0 | 1 | 0.0%
|
[source-hive/src/main/java/org/apache/kylin/source/hive/MRHiveDictUtil.java](https://coveralls.io/builds/31841907/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FMRHiveDictUtil.java#L138)
| 0 | 1 | 0.0%
|
[source-hive/src/main/java/org/apache/kylin/source/hive/HiveInputBase.java](https://coveralls.io/builds/31841907/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FHiveInputBase.java#L376)
| 0 | 2 | 0.0%
|
[engine-mr/src/main/java/org/apache/kylin/engine/mr/JobBuilderSupport.java](https://coveralls.io/builds/31841907/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2FJobBuilderSupport.java#L383)
| 0 | 3 | 0.0%
|
[core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/31841907/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L705)
| 0 | 8 | 0.0%
|
[core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java](https://coveralls.io/builds/31841907/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FCubeDesc.java#L1624)
| 0 | 13 | 0.0%
<!-- | **Total:** | **0** | **31** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
|
[core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/31841907/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L613)
| 1 | 13.7% |
|
[core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/31841907/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124)
| 2 | 68.46% |
|
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/31841907/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449)
| 3 | 78.42% |
|
[tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/31841907/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L42)
| 3 | 77.78% |
<!-- | **Total:** | **9** | | -->
| Totals | [](https://coveralls.io/builds/31841907)
|
| :-- | --: |
| Change from base [Build 6065](https://coveralls.io/builds/31633725): |
0.002% |
| Covered Lines: | 26111 |
| Relevant Lines: | 93332 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> The value of config kylin.source.hive.databasedir can be self detected
> ----------------------------------------------------------------------
>
> Key: KYLIN-4616
> URL: https://issues.apache.org/jira/browse/KYLIN-4616
> Project: Kylin
> Issue Type: Improvement
> Reporter: Zhong Yanghong
> Assignee: Zhong Yanghong
> Priority: Major
>
> We can detect the value of config hive.metastore.warehouse.dir from the
> hive-site.xml. Then we can set the value of config
> kylin.source.hive.databasedir by:
> * If kylin.dictionary.mr-hive.database is empty, then use
> get("hive.metastore.warehouse.dir");
> * else use get("hive.metastore.warehouse.dir") + "/" +
> get("kylin.dictionary.mr-hive.database")+".db"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)