[
https://issues.apache.org/jira/browse/KYLIN-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150843#comment-17150843
]
ASF GitHub Bot commented on KYLIN-4607:
---------------------------------------
coveralls commented on pull request #1292:
URL: https://github.com/apache/kylin/pull/1292#issuecomment-653435264
## Pull Request Test Coverage Report for [Build
6101](https://coveralls.io/builds/31843083)
* **0** of **6** **(0.0%)** changed or added relevant lines in **2**
files are covered.
* **33** unchanged lines in **7** files lost coverage.
* Overall coverage decreased (**-0.03%**) to **27.941%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
|
[core-job/src/main/java/org/apache/kylin/job/impl/threadpool/FetcherRunner.java](https://coveralls.io/builds/31843083/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FFetcherRunner.java#L95)
| 0 | 1 | 0.0%
|
[core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DistributedScheduler.java](https://coveralls.io/builds/31843083/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDistributedScheduler.java#L239)
| 0 | 5 | 0.0%
<!-- | **Total:** | **0** | **6** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
|
[core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/31843083/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L99)
| 1 | 81.4% |
|
[core-job/src/main/java/org/apache/kylin/job/impl/threadpool/FetcherRunner.java](https://coveralls.io/builds/31843083/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FFetcherRunner.java#L86)
| 3 | 73.68% |
|
[tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/31843083/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L42)
| 3 | 77.78% |
|
[core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java](https://coveralls.io/builds/31843083/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FMetricsSystem.java#L58)
| 4 | 60.0% |
|
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/31843083/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L75)
| 5 | 54.55% |
|
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/FragmentData.java](https://coveralls.io/builds/31843083/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FFragmentData.java#L99)
| 7 | 75.68% |
|
[core-job/src/main/java/org/apache/kylin/job/execution/ExecutableManager.java](https://coveralls.io/builds/31843083/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fexecution%2FExecutableManager.java#L492)
| 10 | 36.44% |
<!-- | **Total:** | **33** | | -->
| Totals | [](https://coveralls.io/builds/31843083)
|
| :-- | --: |
| Change from base [Build 6065](https://coveralls.io/builds/31633725): |
-0.03% |
| Covered Lines: | 26078 |
| Relevant Lines: | 93332 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> destributed scheduler kill job instead of fetcherRunner kill job
> -----------------------------------------------------------------
>
> Key: KYLIN-4607
> URL: https://issues.apache.org/jira/browse/KYLIN-4607
> Project: Kylin
> Issue Type: Bug
> Components: Job Engine
> Affects Versions: v3.0.0-alpha
> Reporter: chuxiao
> Assignee: chuxiao
> Priority: Major
>
> see KYLIN-4250
> For DistributedScheduler, even if FetchFailed is true, not in runningJobs,
> the status is running, FetchRunner should not kill the job because the job
> may be scheduler by another kylin service. So destributed scheduler kill job
> when isMetaDataPersistException
> 注释掉了一个测试用例，这个用例依赖的逻辑是task状态异常，但metastore有问题作业异常状态无法持久化，于是通过fetcher把运行状态改成异常状态。这个逻辑是有问题的。
> 对DefaultScheduler来说，如果JobRunner抓到持久化异常，会执行强杀作业逻辑，强杀会一直循环直到成功，是不需要fetcher再去强杀的，因为如果持久化异常导致JobRunner强杀未成功，fetcher也不会成功。
> 而对于DistributedScheduler来说，fetcher的强杀逻辑会把其他进程正在running的作业给误杀
> 掉，更不能保留。
> 详见https://zhuanlan.zhihu.com/p/154376900
> 所以这个case可以删掉
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
