[
https://issues.apache.org/jira/browse/KYLIN-4621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153428#comment-17153428
]
ASF GitHub Bot commented on KYLIN-4621:
---------------------------------------
hit-lacus commented on a change in pull request #1310:
URL: https://github.com/apache/kylin/pull/1310#discussion_r451410546
##########
File path:
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
##########
@@ -2712,6 +2714,22 @@ public boolean isSparkEngineEnabled() {
return
Boolean.parseBoolean(getOptional("kylin.query.spark-engine.enabled", "true"));
}
+ public String getLogSparkPropertiesFile() {
+ return getLogPropertyFile("kylin-parquet-log4j.properties");
+ }
+
+ private String getLogPropertyFile(String filename) {
+ String parentFolder;
+ if (isDevEnv()) {
+ parentFolder = Paths.get(getKylinHomeWithoutWarn(), "build",
"conf").toString();
+ } else if (Files.exists(Paths.get(getKylinHomeWithoutWarn(), "conf",
filename))) {
+ parentFolder = Paths.get(getKylinHomeWithoutWarn(),
"conf").toString();
+ } else {
+ parentFolder = Paths.get(getKylinHomeWithoutWarn(), "server",
"conf").toString();
Review comment:
In which case did `$KYLIN_HOME/server/conf` exists?
##########
File path: build/conf/kylin-parquet-log4j.properties
##########
@@ -0,0 +1,31 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+
+#overall config
+log4j.rootLogger=WARN,hdfs,stdout
+log4j.logger.org.apache.kylin=DEBUG
+log4j.logger.org.springframework=WARN
+log4j.logger.org.springframework.security=WARN
+log4j.logger.org.apache.spark=WARN
+log4j.logger.org.apache.spark.ContextCleaner=WARN
+
+log4j.appender.stdout=org.apache.log4j.ConsoleAppender
Review comment:
I am not really sure, but I want to ask why not write log into a file?
##########
File path: build/conf/kylin-parquet-log4j.properties
##########
@@ -0,0 +1,31 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+
+#overall config
+log4j.rootLogger=WARN,hdfs,stdout
Review comment:
What is `hdfs`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Avoid annoying log message when build cube and query
> ----------------------------------------------------
>
> Key: KYLIN-4621
> URL: https://issues.apache.org/jira/browse/KYLIN-4621
> Project: Kylin
> Issue Type: Improvement
> Components: Spark Engine
> Affects Versions: v4.0.0-beta
> Reporter: wangrupeng
> Assignee: wangrupeng
> Priority: Major
> Fix For: v4.0.0-beta
>
>
> # Build
> There will be about 40 thousands rows log messages of one build task,
> most of them are unnecessary.
> # Query
> The first time of query, kylin will init one spark context and print all
> jars and classes loaded. This can be print in kylin.out not kylin.log.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
