guangxuCheng commented on a change in pull request #1259:
URL: https://github.com/apache/kylin/pull/1259#discussion_r452232378



##########
File path: 
core-metadata/src/main/java/org/apache/kylin/measure/topn/TopNCounter.java
##########
@@ -98,8 +101,17 @@ public void sortAndRetain() {
         ordered = true;

Review comment:
       done

##########
File path: 
core-metadata/src/main/java/org/apache/kylin/measure/topn/TopNCounter.java
##########
@@ -43,8 +43,10 @@
 public class TopNCounter<T> implements Iterable<Counter<T>>, 
java.io.Serializable {
 
     public static final int EXTRA_SPACE_RATE = 50;
+    public static final int EXTRA_SORT_RATE = 10;

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to