[
https://issues.apache.org/jira/browse/KYLIN-4567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159111#comment-17159111
]
ASF GitHub Bot commented on KYLIN-4567:
---------------------------------------
coveralls commented on pull request #1259:
URL: https://github.com/apache/kylin/pull/1259#issuecomment-659332009
## Pull Request Test Coverage Report for [Build
6158](https://coveralls.io/builds/32109511)
* **18** of **23** **(78.26%)** changed or added relevant lines in **3**
files are covered.
* **7** unchanged lines in **3** files lost coverage.
* Overall coverage increased (+**0.02%**) to **28.04%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
|
[core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/32109511/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L1642)
| 0 | 1 | 0.0%
|
[core-metadata/src/main/java/org/apache/kylin/measure/topn/TopNAggregator.java](https://coveralls.io/builds/32109511/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Ftopn%2FTopNAggregator.java#L44)
| 0 | 4 | 0.0%
<!-- | **Total:** | **18** | **23** | **78.26%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
|
[core-metadata/src/main/java/org/apache/kylin/measure/topn/TopNAggregator.java](https://coveralls.io/builds/32109511/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Ftopn%2FTopNAggregator.java#L64)
| 1 | 0% |
|
[tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/32109511/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L44)
| 1 | 83.33% |
|
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/32109511/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
| 5 | 77.81% |
<!-- | **Total:** | **7** | | -->
| Totals | [](https://coveralls.io/builds/32109511)
|
| :-- | --: |
| Change from base [Build 6149](https://coveralls.io/builds/32034523): |
0.02% |
| Covered Lines: | 26240 |
| Relevant Lines: | 93579 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve TopN merge performance in MR engine
> -------------------------------------------
>
> Key: KYLIN-4567
> URL: https://issues.apache.org/jira/browse/KYLIN-4567
> Project: Kylin
> Issue Type: Improvement
> Components: Measure - TopN
> Reporter: Guangxu Cheng
> Assignee: Guangxu Cheng
> Priority: Major
>
> We have a cube that needs to calculate the TOPN of 13 columns. The number of
> data source is only 500k. But, the cubing job always fail when building base
> cuboid.
> we found that the map task always killed by the ApplicationMaster due to time
> out
> {noformat}
> ERROR-[-10001]-[MR]:[Mr Task
> Timeout]:[AttemptID:attempt_1591996262448_229922_m_000000_1 Timed out after
> 3600 secs!] ERROR-[-10015]-[MR]:[Container Exit Accidentally]:[Container
> killed by the ApplicationMaster. Container killed on request. Exit code is
> 143 Container exited with a non-zero exit code 143 ]
> {noformat}
> the stack information as below:
> {noformat}
> "SpillThread" #35 daemon prio=5 os_prio=0 tid=0x00007f9a89771800 nid=0x133a2
> runnable [0x00007f9a56e3f000]
> java.lang.Thread.State: RUNNABLE
> at java.util.LinkedList.toArray(LinkedList.java:1052)
> at java.util.List.sort(List.java:477)
> at java.util.Collections.sort(Collections.java:175)
> at
> org.apache.kylin.measure.topn.TopNCounter.sortAndRetain(TopNCounter.java:96)
> at
> org.apache.kylin.measure.topn.TopNCounter.merge(TopNCounter.java:183)
> at
> org.apache.kylin.measure.topn.TopNAggregator.aggregate(TopNAggregator.java:44)
> at
> org.apache.kylin.measure.topn.TopNAggregator.aggregate(TopNAggregator.java:27)
> at
> org.apache.kylin.measure.MeasureAggregators.aggregate(MeasureAggregators.java:83)
> at
> org.apache.kylin.engine.mr.steps.CuboidReducer.doReduce(CuboidReducer.java:108)
> at
> org.apache.kylin.engine.mr.steps.CuboidReducer.doReduce(CuboidReducer.java:44)
> at
> org.apache.kylin.engine.mr.KylinReducer.reduce(KylinReducer.java:77)
> at org.apache.hadoop.mapreduce.Reducer.run(Reducer.java:171)
> at
> org.apache.hadoop.mapred.Task$NewCombinerRunner.combine(Task.java:1688)
> at
> org.apache.hadoop.mapred.MapTask$MapOutputBuffer.sortAndSpill(MapTask.java:1645)
> at
> org.apache.hadoop.mapred.MapTask$MapOutputBuffer.access$900(MapTask.java:884)
> at
> org.apache.hadoop.mapred.MapTask$MapOutputBuffer$SpillThread.run(MapTask.java:1540)
> {noformat}
> From the stack information, we found that sorting takes a lot of time. After
> merge another counter into this counter, need to re-sort this counter. Maybe
> we can reduce the frequency of sorting
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
