hit-lacus commented on a change in pull request #1362:
URL: https://github.com/apache/kylin/pull/1362#discussion_r471917346
##########
File path:
core-dictionary/src/main/java/org/apache/kylin/dict/DictionaryGenerator.java
##########
@@ -109,6 +109,7 @@ public static Dictionary mergeDictionaries(DataType
dataType, List<DictionaryInf
@Nullable
@Override
public Dictionary<String> apply(@Nullable DictionaryInfo input) {
Review comment:
Let us remove this `Nullable` Annotation because it is confilct with
`checkNotNull`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
