[ 
https://issues.apache.org/jira/browse/KYLIN-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185548#comment-17185548
 ] 

ASF GitHub Bot commented on KYLIN-4698:
---------------------------------------

hit-lacus commented on a change in pull request #1376:
URL: https://github.com/apache/kylin/pull/1376#discussion_r477937494



##########
File path: 
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
##########
@@ -307,6 +307,7 @@ public String getHdfsWorkingDirectory() {
         String metaId = getMetadataUrlPrefix().replace(':', '-');
         //transform relative path for local metadata
         if (metaId.startsWith("../")) {
+            metaId = metaId.replace("../", "");

Review comment:
       This replace action looks confusing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Delete segment storage path after merging segment, deleting segment and 
> droping cube
> ------------------------------------------------------------------------------------
>
>                 Key: KYLIN-4698
>                 URL: https://issues.apache.org/jira/browse/KYLIN-4698
>             Project: Kylin
>          Issue Type: Bug
>          Components: Storage - Parquet
>    Affects Versions: v4.0.0-alpha
>            Reporter: Zhichao  Zhang
>            Assignee: Zhichao  Zhang
>            Priority: Minor
>
> It doesn't delete segment storage path when merge segments, delete segments 
> and drop cube for Kylin 4.0



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to