[GitHub] [kylin] hit-lacus commented on a change in pull request #1376: KYLIN-4698 Delete segment storage path after merging segment, deleting segment and droping cube

[GitBox]

hit-lacus commented on a change in pull request #1376:
URL: https://github.com/apache/kylin/pull/1376#discussion_r477945116



##########
File path: 
kylin-spark-project/kylin-spark-engine/src/test/java/org/apache/kylin/engine/spark/LocalWithSparkSessionTest.java
##########
@@ -191,7 +201,15 @@ protected ExecutableState mergeSegments(String cubeName, 
long start, long end, b
         CubeSegment mergeSegment = cubeMgr.mergeSegments(cube, new 
SegmentRange.TSRange(start, end), null, force);
         NSparkMergingJob mergeJob = NSparkMergingJob.merge(mergeSegment,  
"ADMIN");
         execMgr.addJob(mergeJob);
-        return wait(mergeJob);

Review comment:
       Why remove `wait` method?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org