zzcclp commented on pull request #1360: URL: https://github.com/apache/kylin/pull/1360#issuecomment-683526784
I hava tested this pr on docker, it worked fine, test steps: 1. when building a segment, check the path '/tmp/hbase-staging', there were some 'partitions_' files; 2. when build successfully, the '/tmp/hbase-staging/partitions_' files were deleted; 3. set property 'hbase.fs.tmp.dir' to '/tmp/hbase-tmp', and re-run step 1 and step 2, the 'partitions_' which were in '/tmp/hbase-tmp' were deleted when build successfully, it worked fine. LGTM, and @hit-lacus please review ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
