[
https://issues.apache.org/jira/browse/KYLIN-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17204439#comment-17204439
]
ASF GitHub Bot commented on KYLIN-4697:
---------------------------------------
coveralls commented on pull request #1433:
URL: https://github.com/apache/kylin/pull/1433#issuecomment-701145737
## Pull Request Test Coverage Report for [Build
6417](https://coveralls.io/builds/33818665)
* **0** of **17** **(0.0%)** changed or added relevant lines in **5**
files are covered.
* **10** unchanged lines in **2** files lost coverage.
* Overall coverage decreased (**-0.01%**) to **28.041%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
|
[server-base/src/main/java/org/apache/kylin/rest/controller/UserController.java](https://coveralls.io/builds/33818665/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FUserController.java#L220)
| 0 | 1 | 0.0%
|
[server-base/src/main/java/org/apache/kylin/rest/security/KylinUserManager.java](https://coveralls.io/builds/33818665/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsecurity%2FKylinUserManager.java#L144)
| 0 | 1 | 0.0%
|
[server-base/src/main/java/org/apache/kylin/rest/service/KylinUserService.java](https://coveralls.io/builds/33818665/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FKylinUserService.java#L214)
| 0 | 1 | 0.0%
|
[server-base/src/main/java/org/apache/kylin/rest/service/KylinUserGroupService.java](https://coveralls.io/builds/33818665/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FKylinUserGroupService.java#L157)
| 0 | 3 | 0.0%
|
[server-base/src/main/java/org/apache/kylin/rest/security/KylinAuthenticationProvider.java](https://coveralls.io/builds/33818665/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsecurity%2FKylinAuthenticationProvider.java#L119)
| 0 | 11 | 0.0%
<!-- | **Total:** | **0** | **17** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
|
[server-base/src/main/java/org/apache/kylin/rest/security/KylinAuthenticationProvider.java](https://coveralls.io/builds/33818665/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsecurity%2FKylinAuthenticationProvider.java#L150)
| 1 | 0% |
|
[core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java](https://coveralls.io/builds/33818665/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FMetricsSystem.java#L46)
| 9 | 60.0% |
<!-- | **Total:** | **10** | | -->
| Totals | [](https://coveralls.io/builds/33818665)
|
| :-- | --: |
| Change from base [Build 6416](https://coveralls.io/builds/33804340): |
-0.01% |
| Covered Lines: | 26251 |
| Relevant Lines: | 93616 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> User info update logic is not correct
> -------------------------------------
>
> Key: KYLIN-4697
> URL: https://issues.apache.org/jira/browse/KYLIN-4697
> Project: Kylin
> Issue Type: Bug
> Reporter: Zhong Yanghong
> Assignee: JiangYang
> Priority: Major
> Fix For: v3.1.1
>
>
> There are mainly two issues:
> * The logic for KylinAuthenticationProvider.needUpdateUser() is not correct
> due to not considering ALL_USERS
> * The logic of updateUser in some places is not correct due to not following
> copy on write.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
