[
https://issues.apache.org/jira/browse/KYLIN-4799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223325#comment-17223325
]
ASF GitHub Bot commented on KYLIN-4799:
---------------------------------------
shaofengshi commented on pull request #1466:
URL: https://github.com/apache/kylin/pull/1466#issuecomment-719123933
LGTM, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Let me know contribution guide
> ------------------------------
>
> Key: KYLIN-4799
> URL: https://issues.apache.org/jira/browse/KYLIN-4799
> Project: Kylin
> Issue Type: Improvement
> Reporter: yoonsung.lee
> Priority: Trivial
> Labels: documentation
>
> Hi. I'm preparing to solve some issues that I'm interested in.
> I cannot find CONTRIBUTING.md and CODE_OF_CONDUCT.md in the Github repository.
>
> Please let me know. If there doesn't exist, please consider making it to
> invigorate this project. The contribution guide will make the code of this
> project reliable and reduce communication costs.
>
> The followings are some properties that I expect it in the contribution guide.
> * Code style schema for IDE such as IntelliJ, vscode, vim, and etc.
> * Copyright header.
> * Guide for null check in Java.
> * Guide for access modifier in Java
> * Guide to organize code in a java class.
> * Guide for the message of exception or log.
> * Guide for write Javadoc when creating a class.
> * Rest API convention.
> * etc...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
