zhengshengjun commented on a change in pull request #1477:
URL: https://github.com/apache/kylin/pull/1477#discussion_r523406851
##########
File path:
core-dictionary/src/main/java/org/apache/kylin/dict/TrieDictionaryBuilder.java
##########
@@ -152,10 +158,10 @@ else if (comp > 0)
}
if (found) {
// found a child node matching the first byte, continue in that
child
- addValueR(node.children.get(mid), value, j);
+ addValueR(node.children.get(mid), value, j, isSplitValue);
} else {
// otherwise, make the value a new child
- Node c = new Node(BytesUtil.subarray(value, j, nn), true);
+ Node c = new Node(BytesUtil.subarray(value, j, nn), isSplitValue ?
false : true);
Review comment:
thanks for your reviewing and advice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
