hit-lacus commented on a change in pull request #1496:
URL: https://github.com/apache/kylin/pull/1496#discussion_r536012522



##########
File path: tool/src/main/java/org/apache/kylin/tool/CubeMigrationCLI.java
##########
@@ -326,22 +292,32 @@ protected void listCubeRelatedResources(CubeInstance 
cube, List<String> metaReso
         metaResource.addAll(getCompatibleTablePath(tblRefs, prj, 
ResourceStore.TABLE_EXD_RESOURCE_ROOT));
 
         if (doMigrateSegment) {
+            for (DictionaryDesc dictionaryDesc : cubeDesc.getDictionaries()) {
+                String[] columnInfo = 
dictionaryDesc.getColumnRef().getColumnWithTable().split("\\.");
+                String globalDictPath;
+                if (columnInfo.length == 3) {

Review comment:
       In which case `columnInfo.length` is not 3?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to