[
https://issues.apache.org/jira/browse/KYLIN-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17250074#comment-17250074
]
ASF GitHub Bot commented on KYLIN-4842:
---------------------------------------
hit-lacus commented on a change in pull request #1512:
URL: https://github.com/apache/kylin/pull/1512#discussion_r543869913
##########
File path:
kylin-spark-project/kylin-spark-common/src/test/java/org/apache/spark/sql/common/SparkQueryTest.scala
##########
@@ -116,9 +116,9 @@ object SparkQueryTest {
|== Results ==
|${
sideBySide(
- s"== Kylin Answer - ${kylinAnswer.size} ==" +:
+ s"== Expected Answer - ${kylinAnswer.size} ==" +:
Review comment:
Is it correct ? I think `sparkResults` should be the expected result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Supports grouping sets function for Kylin 4
> -------------------------------------------
>
> Key: KYLIN-4842
> URL: https://issues.apache.org/jira/browse/KYLIN-4842
> Project: Kylin
> Issue Type: New Feature
> Components: Query Engine
> Affects Versions: v4.0.0-alpha
> Reporter: Zhichao Zhang
> Assignee: Zhichao Zhang
> Priority: Minor
> Fix For: v4.0.0-beta
>
>
> Currently Kylin 4 can not support grouping sets function, bacause it doesn't
> transform calcite grouping sets node to spark GroupingSets.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
