[
https://issues.apache.org/jira/browse/KYLIN-4850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255943#comment-17255943
]
ASF GitHub Bot commented on KYLIN-4850:
---------------------------------------
zhengshengjun commented on a change in pull request #1523:
URL: https://github.com/apache/kylin/pull/1523#discussion_r549667034
##########
File path:
kylin-spark-project/kylin-spark-engine/src/main/java/org/apache/kylin/engine/spark/job/NSparkExecutable.java
##########
@@ -105,7 +105,7 @@ protected ExecuteResult doWork(ExecutableContext context)
throws ExecuteExceptio
//context.setLogPath(getSparkDriverLogHdfsPath(context.getConfig()));
CubeManager cubeMgr =
CubeManager.getInstance(KylinConfig.getInstanceFromEnv());
CubeInstance cube = cubeMgr.getCube(this.getCubeName());
- KylinConfig config = cube.getConfig();
+ KylinConfig config = KylinConfigExt.createInstance(cube.getConfig(),
cube.getDescriptor().getOverrideKylinProps());
Review comment:
thansks you for your advice ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Cube's override kylin_properties were ignored in building jobs
> --------------------------------------------------------------
>
> Key: KYLIN-4850
> URL: https://issues.apache.org/jira/browse/KYLIN-4850
> Project: Kylin
> Issue Type: Improvement
> Components: Job Engine
> Affects Versions: v4.0.0-alpha
> Reporter: ShengJun Zheng
> Priority: Minor
>
> Cube's override kylin_properties were ignored in building jobs, it prevent us
> from optimizing spark configurations of some special cubes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
