[ 
https://issues.apache.org/jira/browse/KYLIN-4853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256964#comment-17256964
 ] 

ASF GitHub Bot commented on KYLIN-4853:
---------------------------------------

codecov-io commented on pull request #1532:
URL: https://github.com/apache/kylin/pull/1532#issuecomment-752939754


   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1532?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`kylin-on-parquet-v2@32f8d66`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/1532/graphs/tree.svg?width=650&height=150&src=pr&token=JawVgbgsVo)](https://codecov.io/gh/apache/kylin/pull/1532?src=pr&el=tree)
   
   ```diff
   @@                  Coverage Diff                   @@
   ##             kylin-on-parquet-v2    #1532   +/-   ##
   ======================================================
     Coverage                       ?   24.31%           
     Complexity                     ?     4621           
   ======================================================
     Files                          ?     1138           
     Lines                          ?    64446           
     Branches                       ?     9515           
   ======================================================
     Hits                           ?    15672           
     Misses                         ?    47139           
     Partials                       ?     1635           
   ```
   
   
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/1532?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/1532?src=pr&el=footer). Last 
update 
[32f8d66...2cf9b0b](https://codecov.io/gh/apache/kylin/pull/1532?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> QueryPreparedStatementCache invalid in Spark Query Engine
> ---------------------------------------------------------
>
>                 Key: KYLIN-4853
>                 URL: https://issues.apache.org/jira/browse/KYLIN-4853
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: ShengJun Zheng
>            Priority: Blocker
>
> Prepare statement cache  imported from  KYLIN-3434 get invalid in SparkQuery 
> Engine.
> In SparkQuery Engine, physical plan will be created directly from RelNode, 
> which was not cached, it will cause  prepared statment query fail after first 
> successful query.
> Error Stack like this:
> {code:java}
> ava.sql.SQLException: exception while executing query: 
> java.lang.NullPointerException
>         at org.apache.calcite.avatica.Helper.createException(Helper.java:56)
>         at org.apache.calcite.avatica.Helper.createException(Helper.java:41)
>         at 
> org.apache.calcite.avatica.AvaticaConnection.executeQueryInternal(AvaticaConnection.java:577)
>         at 
> org.apache.calcite.avatica.AvaticaPreparedStatement.executeQuery(AvaticaPreparedStatement.java:137)
>         at 
> org.apache.kylin.rest.service.QueryService.executePrepareRequest(QueryService.java:1032)
>         at 
> org.apache.kylin.rest.service.QueryService.queryWithSqlMassage(QueryService.java:718)
> Caused by: java.lang.RuntimeException: java.lang.NullPointerException
>         at 
> org.apache.kylin.query.exec.SparkExec.collectToEnumerable(SparkExec.java:46)
>         at Baz.bind(Unknown Source)
>         at 
> org.apache.calcite.jdbc.CalcitePrepare$CalciteSignature.enumerable(CalcitePrepare.java:365)
>         at 
> org.apache.calcite.jdbc.CalciteConnectionImpl.enumerable(CalciteConnectionImpl.java:301)
>         at 
> org.apache.calcite.jdbc.CalciteMetaImpl._createIterable(CalciteMetaImpl.java:559)
>         at 
> org.apache.calcite.jdbc.CalciteMetaImpl.createIterable(CalciteMetaImpl.java:550)
>         at 
> org.apache.calcite.avatica.AvaticaResultSet.execute(AvaticaResultSet.java:182)
>         at 
> org.apache.calcite.jdbc.CalciteResultSet.execute(CalciteResultSet.java:67)
>         at 
> org.apache.calcite.jdbc.CalciteResultSet.execute(CalciteResultSet.java:44)
>         at 
> org.apache.calcite.avatica.AvaticaConnection.executeQueryInternal(AvaticaConnection.java:573)
>         ... 84 more
> Caused by: java.lang.NullPointerException
>         at 
> org.apache.kylin.query.runtime.CalciteToSparkPlaner.visit(CalciteToSparkPlaner.scala:45)
>         at org.apache.calcite.rel.RelVisitor.go(RelVisitor.java:61)
>         at 
> org.apache.kylin.query.runtime.SparkEngine.toSparkPlan(SparkEngine.java:61)
>         at 
> org.apache.kylin.query.runtime.SparkEngine.compute(SparkEngine.java:49)
>         at 
> org.apache.kylin.query.exec.QueryEngineFactory.compute(QueryEngineFactory.java:47)
>         at 
> org.apache.kylin.query.exec.SparkExec.collectToEnumerable(SparkExec.java:43)
> {code}
>  
> I  solved this by cache RelNode to avoid SQL be parsed, optimized, code gen 
> again. wonder if there is better way. thanks ~
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to