[
https://issues.apache.org/jira/browse/KYLIN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17257715#comment-17257715
]
ASF GitHub Bot commented on KYLIN-4855:
---------------------------------------
codecov-io edited a comment on pull request #1534:
URL: https://github.com/apache/kylin/pull/1534#issuecomment-753489521
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1534?src=pr&el=h1) Report
> Merging
[#1534](https://codecov.io/gh/apache/kylin/pull/1534?src=pr&el=desc) (47a6958)
into
[master](https://codecov.io/gh/apache/kylin/commit/c962a233672245c92db8ea29ee2f2540adbcc708?el=desc)
(c962a23) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1534?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1534 +/- ##
============================================
- Coverage 25.46% 25.44% -0.02%
+ Complexity 6765 6762 -3
============================================
Files 1507 1507
Lines 93795 93795
Branches 13135 13135
============================================
- Hits 23886 23870 -16
- Misses 67532 67543 +11
- Partials 2377 2382 +5
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/1534?src=pr&el=tree) | Coverage
Δ | Complexity Δ | |
|---|---|---|---|
|
[...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1534/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==)
| `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | |
|
[.../apache/kylin/tool/query/ProbabilityGenerator.java](https://codecov.io/gh/apache/kylin/pull/1534/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9xdWVyeS9Qcm9iYWJpbGl0eUdlbmVyYXRvci5qYXZh)
| `71.05% <0.00%> (-5.27%)` | `11.00% <0.00%> (ø%)` | |
|
[...che/kylin/stream/core/storage/CheckPointStore.java](https://codecov.io/gh/apache/kylin/pull/1534/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvQ2hlY2tQb2ludFN0b3JlLmphdmE=)
| `63.63% <0.00%> (-3.04%)` | `21.00% <0.00%> (-1.00%)` | |
|
[...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1534/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh)
| `73.25% <0.00%> (-2.33%)` | `12.00% <0.00%> (ø%)` | |
|
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1534/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
| `69.30% <0.00%> (-1.83%)` | `7.00% <0.00%> (ø%)` | |
|
[...va/org/apache/kylin/tool/query/QueryGenerator.java](https://codecov.io/gh/apache/kylin/pull/1534/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9xdWVyeS9RdWVyeUdlbmVyYXRvci5qYXZh)
| `80.00% <0.00%> (-1.12%)` | `23.00% <0.00%> (-1.00%)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/1534?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/1534?src=pr&el=footer). Last
update
[c962a23...47a6958](https://codecov.io/gh/apache/kylin/pull/1534?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> kylin metrics prefix bug in system-cube.sh
> ------------------------------------------
>
> Key: KYLIN-4855
> URL: https://issues.apache.org/jira/browse/KYLIN-4855
> Project: Kylin
> Issue Type: Bug
> Components: Environment
> Affects Versions: v2.6.0
> Environment: 2.6.0+
> Reporter: huajiewang
> Priority: Minor
> Labels: easyfix
> Fix For: Future
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> After executed "system-cube.sh cron", the system cube will be added to the
> crontab, but the cube name is wrong, and it does not match the actual
> situation. After testing, it is found that the system-cube is
> There is a bug in the handling of kylin metrics prefix
> In the system-cube.sh script, the prefix is "KYLIN". The logic is wrong. You
> should get "kylin.metrics.prefix" from kylin.properties. If this item is set,
> take the value set by the user, if not set, go to the default value. "KYLIN"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
